Date: Thu, 2 Feb 2006 15:43:28 +0300 From: Yar Tikhiy <yar@comp.chem.msu.su> To: Ruslan Ermilov <ru@freebsd.org> Cc: Luigi Rizzo <rizzo@icir.org>, Hajimu UMEMOTO <ume@freebsd.org>, mlaier@freebsd.org, net@freebsd.org Subject: Re: if_bridge.ko requires INET6... Message-ID: <20060202124328.GK29980@comp.chem.msu.su> In-Reply-To: <20060202070149.GD18601@ip.net.ua> References: <20060201005658.A70005@xorpc.icir.org> <20060201090421.GT4297@FreeBSD.org> <ygehd7jquvd.wl%ume@mahoroba.org> <20060201103746.GD90360@ip.net.ua> <20060201224939.GB29980@comp.chem.msu.su> <20060202070149.GD18601@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 02, 2006 at 09:01:49AM +0200, Ruslan Ermilov wrote: > On Thu, Feb 02, 2006 at 01:49:40AM +0300, Yar Tikhiy wrote: > > On Wed, Feb 01, 2006 at 12:37:46PM +0200, Ruslan Ermilov wrote: > > > On Wed, Feb 01, 2006 at 06:41:10PM +0900, Hajimu UMEMOTO wrote: > > > > >>>>> On Wed, 1 Feb 2006 12:04:21 +0300 > > > > >>>>> Gleb Smirnoff <glebius@FreeBSD.org> said: > > > > > > > > glebius> If you have compiled the modules as part of buildkernel > > > > glebius> target, then all options from kernel would apply to all > > > > glebius> modules, thus the bridge_ip6_checkbasic() function won't > > > > glebius> be present in if_bridge.ko, and you would successfully > > > > glebius> load the module. > > > > > > > > I believe it is 7-CURRENT thing, and is not MFCed yet. So, if it is > > > > on 6.x, you need -DNO_INET6 to build if_bridge.ko. > > > > > > > Ask yar@ to MFC his modules/ mega-commit that fixed this in HEAD. > > > I'd really love to see it in 6.1. > > > > I haven't considered that an option since two issues were found > > related to my mega-commit. One was that if_gif wouln't load due > > to unresolved symbols if built w/o INET6. The other was in the > > pf module -- pflog would be lost as it didn't have a separate module. > > > > The essence of the first issue is that the set of source files > > for a module cannot depend on kernel options, unlike for the main > > kernel file. > > > I thought I've fixed it in December (in CVS). I'm running if_gif.ko > without any problems on INET6-less kernel. I missed your commit to the if_gif module. I hope you'll forgive me if I say it is a mere hack, but it will do for now :-) > > The second issue has to do with the fact that pflog is more to > > a plain option than to a device, as there are `#ifdef DEV_PFLOG' > > lines in the pf code conditionalizing the pflog feature. > > > This needs to be fixed in pf then. Max Laier and I discussed this issue once, and Max had concern over possible performance degradation that might result from calling pflog functions through pointers to be set by a separate pflog module. We can skip touching the pf module in RELENG_6 for now and leave the issue to after 6.1-RELEASE is out. -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060202124328.GK29980>