Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Mar 2024 20:16:31 GMT
From:      Yuri Victorovich <yuri@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: bd78a1b4103a - main - databases/arrow: Fix build on 13.2
Message-ID:  <202403272016.42RKGVYR001670@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by yuri:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bd78a1b4103aedc78d22c173685d9938ad8b8986

commit bd78a1b4103aedc78d22c173685d9938ad8b8986
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2024-03-27 20:13:29 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2024-03-27 20:16:27 +0000

    databases/arrow: Fix build on 13.2
    
    The TESTING option (enabling the TESTING module) is disabled due to
    googletest incompatibility with C++17 -compiled code on 13.2
    
    PR:             277953
    Reported by:    Palle Girgensohn <girgen@FreeBSD.org>
---
 databases/arrow/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/databases/arrow/Makefile b/databases/arrow/Makefile
index 3df2af72231d..d4545fe4dd76 100644
--- a/databases/arrow/Makefile
+++ b/databases/arrow/Makefile
@@ -178,6 +178,14 @@ TESTING_DESC=			Arrow testing libraries
 TESTING_CMAKE_BOOL=		ARROW_TESTING
 TESTING_LIB_DEPENDS=		libgtest.so:devel/googletest
 
+# workaround for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277953
+OPSYS!=		uname -s # HACK: OPSYS is defined in bsd.port.options.mk which has to be later
+OSVERSION!=	awk '/^\#define[[:blank:]]__FreeBSD_version/ {print $$3}' < ${CROSS_SYSROOT}/usr/include/sys/param.h # HACK: same as above
+.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1303000
+TESTING_BROKEN=	configure fails because GTest built with C++ level <17 isn't compatible with C++17 used in arrow
+.endif
+
+# form OPTIONS_DEFAULT
 .for opt in ${OPTIONS_GROUP_COMPONENTS}
 .  if "${${opt}_BROKEN}" == ""
 OPTIONS_DEFAULT+=	${opt}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202403272016.42RKGVYR001670>