Date: Thu, 04 Sep 2014 19:15:33 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193294] [maintainer] graphics/repng2jpeg better conformity upgrade version to ???? Message-ID: <bug-193294-13-Go3JdZypaz@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-193294-13@https.bugs.freebsd.org/bugzilla/> References: <bug-193294-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D193294 --- Comment #5 from C Hutchinson <portmaster@bsdforge.com> --- (In reply to John Marino from comment #2) > A) >=20 > -COMMENT=3D Tool to recompress JPEG/PNG/GIF > +COMMENT=3D A small tool to recompress JPEG, PNG, and GIF images >=20 > That's not a good change. > You can't start a comment with "A", "The", "An", or the name of the port. > I don't know why you are changing this line at all actually, but at lease > change "A small tool" to "Tool" (who cares if it's small?) >=20 > B) > Since you are controlling the source, please increment the version instead > of rerolling the source tarball. That's a huge faux-pas. We are supposed > to immediately request to upstreams that re-roll tarballs to stop it and > don't do it anymore. >=20 > This isn't a "if you can" request. if you want to change the source, eit= her > use patches or roll a new tarball with a new version. >=20 > If you already published the tarball, you also just broke the port, by the > way. It won't fetch anymore. Nope. No faux-pas here. Well, not really. In this case, there was a subtle re-naming change; from: PORTNAME_VERSION, to: PORTNAME-VERSION. Underscore, to hyphen. No possible fetch(1) issue(s) either. I left the previous file as-was, where-was. I thought of all that, already. :) Thanks, John. --Chris --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193294-13-Go3JdZypaz>