From nobody Fri Mar 24 07:08:51 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PjYGW6c71z41BMZ; Fri, 24 Mar 2023 07:08:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PjYGW68KWz4FSk; Fri, 24 Mar 2023 07:08:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679641731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=b+pYj4Er6J+fOzOj3W3soMIFgeRUNxNLxRNlliUoVGM=; b=lKj3lU7PkjRC6mE1OnhQlvDVtOyPA81JPcEcLKJh3M/m1hQ/ctn/aK8oklipFqEALXAKiP xPAZNVxEcA7lY+WaCubFo79ftrPAkhRKuC1I81hvTVxgzDOoc/N0FrY85DoIPgZ8Y4BYat fjx0epwRbwg1dulKSyiXC0qIMG8pMdPG5FV/B3cyyfLa/oSasUB+0fa3tMZlx7MJdBhha4 k5+jz3G8v9ucNygoWe5tw0P9QA37n8RUmadvf+7TMhSrR3GyeERWljE8WKTQ+jOD3DXEGh VCwKNJrL2mSJE6BWOWKMtXJLMnM5H+goo2RskPWZpXqHAVKsmOmu7zBpH2htJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679641731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=b+pYj4Er6J+fOzOj3W3soMIFgeRUNxNLxRNlliUoVGM=; b=VtF7od8HnOwVOhURKgW51KBKusFfc3BiUcpvSRtyfsKGZBWSfUw1uCllLVKojEnUJink7X h9ThUlzIxwNvV/fE7IofAXdgJVju9kAWwR/ot3GTfkGnyUSCUkZMxElAncgAkK0hmBErK6 fMSbdiMt0MrHu+7GDJnci7EanurLNosdZKLkPRGandkBsekj5fUP5pdSgEIU9GPIHzAsDn WRGHM67y6Y/amt3kGAmsC7D2jUXlAVWl0RUqs327P6TNzq0byVz6cd87C0zk/ZdWzZaXrv wPXX4wu1DxXPn0EUhVmXf0zOWtmdwybfmsCqYHypyqBLsgdQJm2dKteLPA1vnA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679641731; a=rsa-sha256; cv=none; b=t3IMeXn8LrutTtZuTbNm0JJQ9qKdtndF5zGSs3iQqbGluJJWqEvhYZDK/OxhrjP24KtxwJ zoOJcpPgxJuqmIz6HBNG5P5HU3lC0drm/v9V2Oqhf55iuEVkkG1UPDkwmIWCBbpi8jzC+J FlGVqmgN027vvmJIaM6Oh7zx9Y+OOlUKtQdzXeX6COQaDFqF6iXJ/BhkTLhGF0tRD1SfxO Sc2wBJJOpOC5JNVvsacr84SSrDKdmbRcAaLkGI3eAusK12OMJy9gPHD9UIN2KVzpdcopDu ttJfY74kr/Coz4K8zWqutwxWX3ZP6kTaLhfjDeroVYTd2yQEIMOZclS2iwFoLw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PjYGW58hfz17Rc; Fri, 24 Mar 2023 07:08:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 32O78piT023751; Fri, 24 Mar 2023 07:08:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 32O78pYi023750; Fri, 24 Mar 2023 07:08:51 GMT (envelope-from git) Date: Fri, 24 Mar 2023 07:08:51 GMT Message-Id: <202303240708.32O78pYi023750@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: ad729f8d503e - main - pf: ignore ip6_output() return value in pf_refragment6() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ad729f8d503e26ddfe4dcc0fa701720c753bd3ba Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=ad729f8d503e26ddfe4dcc0fa701720c753bd3ba commit ad729f8d503e26ddfe4dcc0fa701720c753bd3ba Author: Kristof Provost AuthorDate: 2023-03-24 05:39:01 +0000 Commit: Kristof Provost CommitDate: 2023-03-24 07:08:19 +0000 pf: ignore ip6_output() return value in pf_refragment6() We can't do anything if ip6_output() fails, other than discard the packet which ip6_output() already does for us. Mark the return value as ignored. Reported by: emaste, Coverity Sponsored by: Rubicon Communications, LLC (Netgate) --- sys/netpfil/pf/pf_norm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netpfil/pf/pf_norm.c b/sys/netpfil/pf/pf_norm.c index 8d36e72d71b2..2eb1bd69294c 100644 --- a/sys/netpfil/pf/pf_norm.c +++ b/sys/netpfil/pf/pf_norm.c @@ -1020,7 +1020,8 @@ pf_refragment6(struct ifnet *ifp, struct mbuf **m0, struct m_tag *mtag, MPASS(m->m_pkthdr.rcvif != NULL); ip6_forward(m, 0); } else { - ip6_output(m, NULL, NULL, 0, NULL, NULL, NULL); + (void)ip6_output(m, NULL, NULL, 0, NULL, NULL, + NULL); } else m_freem(m);