From owner-svn-src-all@FreeBSD.ORG Sat Jun 6 16:18:30 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 71F576D5; Sat, 6 Jun 2015 16:18:30 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from mail.xcllnt.net (mail.xcllnt.net [50.0.150.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3940E1346; Sat, 6 Jun 2015 16:18:29 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from [192.168.2.22] (atc.xcllnt.net [50.0.150.213]) (authenticated bits=0) by mail.xcllnt.net (8.14.9/8.14.9) with ESMTP id t56GIMGZ029319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 6 Jun 2015 09:18:23 -0700 (PDT) (envelope-from marcel@xcllnt.net) Subject: Re: svn commit: r284078 - head/sys/dev/pci Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: multipart/signed; boundary="Apple-Mail=_207B226B-160B-4BE9-B25F-24AEBBBAFBC2"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Marcel Moolenaar In-Reply-To: <14005803.mtbqcRkBJG@ralph.baldwin.cx> Date: Sat, 6 Jun 2015 09:18:22 -0700 Cc: Marcel Moolenaar , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201506061551.t56FpCbX013048@svn.freebsd.org> <14005803.mtbqcRkBJG@ralph.baldwin.cx> To: John Baldwin X-Mailer: Apple Mail (2.2098) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jun 2015 16:18:30 -0000 --Apple-Mail=_207B226B-160B-4BE9-B25F-24AEBBBAFBC2 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > On Jun 6, 2015, at 9:03 AM, John Baldwin wrote: > > On Saturday, June 06, 2015 03:51:12 PM Marcel Moolenaar wrote: >> Author: marcel >> Date: Sat Jun 6 15:51:11 2015 >> New Revision: 284078 >> URL: https://svnweb.freebsd.org/changeset/base/284078 >> >> Log: >> Don't return -10000 as the probe priority. That's lower than what >> BUS_PROBE_HOOVER is. Drivers like proto(4), when compiled into the >> kernel or preloaded, will render your system useless by virtue of >> attaching to your PCI busses. >> >> Return BUS_PROBE_GENERIC instead. It's just the next priority up >> from BUS_PROBE_HOOVER. No other meaning has been give to its use. >> While BUS_PROBE_DEFAULT seems like a better candidate, it's hard >> not to think that there must be some reason why these drivers >> return -10000 in the first place. > > BUS_PROBE_DEFAULT would conflict with other drivers that are supposed to > override these, such as acpi_pcib_pci which should override pci_pci > for PCI-PCI bridges in the ACPI namespace. That driver currently hardcodes > -1000 itself. :-/ Then there's pcibios_pcib_probe for the $PIR PCI-PCI > bridge driver for when ACPI isn't present. It returns -2000. The > MPTable PCI-PCI bridge driver returns -1000 like ACPI. So that means we have a regression. Do you want me to back out or should we just move forward and fix those too. An alternative is to change BUS_PROBE_HOOVER to -100000 and be done with it. Thoughts? -- Marcel Moolenaar marcel@xcllnt.net --Apple-Mail=_207B226B-160B-4BE9-B25F-24AEBBBAFBC2 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVcx1OAAoJEIda8t8f0tjjCBUQANIz8UAlVPimSGYGez0HRsBm O5UJXOYArWcgNYfJesU5XkJ9eeLstcPtEZfo64S7iCC4hN1KhXIEI5HonlU8b4b5 GzNx4URq4f6yIZ+T1P3Lj354JaMlHrCVzP4fZ748GXB8YZJbaPFOMlZei/A2jKv2 X0ExIVHBLBLnAWtYFLMrtxkb8y2DqnbwcH5twVvD7q+tvne+syBBQCeWJRlA/4jI deWg8YwmbbQMK/c3xkIWE+YiOK/YwV3cbh+lGjokvWk/2SyQkE2XROwIIjE/bTI7 9oWF/HQPHl5HcGqWUNsWQe71whBxq2tQam6WnSk2iHNeKnDh7PSRY0S3fukAUuPI LWMLuMov5duoqumEcU8W+byT4kRIh0bZsXf/AEtrQ3/gwXRwnhNFyyGoAo3Twci9 GA2MJCXo9jZalhilrIg1r7bCR18ha7+LX7yUTH37BiJpB5z+r9jds9XCsm6lUjvV PsosuCmu/dDm7K88xUPwSCaqTWVvI5/T7roHF6+YOIAHW+ERs+qSMBCNttCbEGQJ YOKX37PfoGlaz4zNGOBA/3wiIvSi/Ks9SKBleTNONyA1ibajQhoWl/bgRUiFiIfz e8jOPn/FcqL3il+vLxzctbKRD1uwL8Vq0ogdFkuWGT46FQBNohALkDYXn6YsIdRa 2540SsBJlX5bwhNj7Jx7 =S0AO -----END PGP SIGNATURE----- --Apple-Mail=_207B226B-160B-4BE9-B25F-24AEBBBAFBC2--