From owner-svn-src-head@freebsd.org Fri Oct 11 08:23:26 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D692C142842; Fri, 11 Oct 2019 08:23:26 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46qLZ65GNGz49lY; Fri, 11 Oct 2019 08:23:26 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi1-f196.google.com with SMTP id x3so7325361oig.2; Fri, 11 Oct 2019 01:23:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=0tKYLRVQpDo/Rln0uRa8GkLWzJSmPykJqd3P0dDf2ck=; b=hoPJtuJLe6nspHFkCDXvr9CsvLNCpiiUJI62FS+/B/mv7L3P4eM/LX1xKj8yYjwAcq MRlLozKZ1vhvgXKsd9HbcxNinyc8tjB0VXXHhypJ+eZj72wnXUgL9vsyQOP1RAzq4t4r jCzQ4IIfLD4ifnH355GhMUr/sBKKa88W9SnjBSxGyh2UEwT21M0PQfcv7cC/2dTTrgrq BPfsDKSiXnd6udrnIpfqNYp6Im80MvUaLscZXr3rAb2HQzCILJVPh70UiLvvK0cm9+vu Z20PSGK+TDmTlVW0eAcSNEuh7bvDZdg+6iOgEJMrKpZnzukvbc3qOrVCvfxkl+HHz7gm 6QGQ== X-Gm-Message-State: APjAAAXB73uegK+IjfEzPpHVazi7x8ziqfU1rtHj3+eyeeSRTsamVMI0 rhcoLuT97ROTj5vz6L12sz2k39CW X-Google-Smtp-Source: APXvYqztVO5rq1JzJpIpGcmQJkIaVrCYNb4h9lifTrJHiiHz7gCObGe5a4LyF6FUCAXIsX8RFeqaXw== X-Received: by 2002:aca:53d0:: with SMTP id h199mr11296460oib.13.1570782203593; Fri, 11 Oct 2019 01:23:23 -0700 (PDT) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com. [209.85.210.43]) by smtp.gmail.com with ESMTPSA id r7sm2473128oih.41.2019.10.11.01.23.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2019 01:23:23 -0700 (PDT) Received: by mail-ot1-f43.google.com with SMTP id o44so7242169ota.10; Fri, 11 Oct 2019 01:23:23 -0700 (PDT) X-Received: by 2002:a9d:6c99:: with SMTP id c25mr9886116otr.157.1570782203143; Fri, 11 Oct 2019 01:23:23 -0700 (PDT) MIME-Version: 1.0 References: <201910101629.x9AGTDkJ024957@repo.freebsd.org> <1ba0202e-698d-7cc4-1907-59d75cfe4332@FreeBSD.org> <137352B5-82C6-4953-9233-282A92FCAFC8@FreeBSD.org> In-Reply-To: <137352B5-82C6-4953-9233-282A92FCAFC8@FreeBSD.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Fri, 11 Oct 2019 01:23:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r353408 - head To: Dimitry Andric Cc: Andriy Gapon , Brooks Davis , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 46qLZ65GNGz49lY X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Oct 2019 08:23:26 -0000 That might be the problem in the CI rig, but xtoolchain on CURRENT doesn't appear to provide the incorrect "12" value, and it's still broken =E2=80=94 nothing to do with gets(3). $ x86_64-unknown-freebsd13.0-gcc-6.4.0 -std=3Dc99 -dM -E - < /dev/null | grep FreeBSD #define __FreeBSD__ 13 The error I hit is the one ostensibly fixed by 353408: make[4]: /obj/usr/home/conrad/src/freebsd/amd64.amd64/sys/GENERIC/modules/u= sr/home/conrad/src/freebsd/sys/modules/opensolaris/.depend.opensolaris_atom= ic.o, 5: ignoring stale .depend for /usr/home/conrad/src/freebsd/sys/cddl/contrib/opensolaris/common/atomic/amd= 64/opensolaris_atomic.S x86_64-unknown-freebsd13.0-gcc: error: /usr/home/conrad/src/freebsd/sys/cddl/contrib/opensolaris/common/atomic/amd= 64/opensolaris_atomic.S: No such file or directory x86_64-unknown-freebsd13.0-gcc: fatal error: no input files Best, Conrad On Fri, Oct 11, 2019 at 1:04 AM Dimitry Andric wrote: > > On 11 Oct 2019, at 08:24, Andriy Gapon wrote: > > > > On 11/10/2019 09:07, Conrad Meyer wrote: > >> Fwiw, this doesn=E2=80=99t seem to fix the NO_CLEAN build for amd64-xt= oolchain-gcc. > > > > Does a clean build work for that configuration? > > I looked at one of CI builds and it had this: > > In file included from /workspace/src/contrib/libc++/include/__debug:26:= 0, > > from /workspace/src/contrib/libc++/include/utility:206, > > from /workspace/src/contrib/libc++/include/algorithm:64= 2, > > from /workspace/src/contrib/libc++/src/algorithm.cpp:9: > > /workspace/src/contrib/libc++/include/cstdio:156:9: error: '::gets' has= not been > > declared > > using ::gets; > > > > I recall seeing a similar problem for riscv too. > > Yes, this is an issue with the external toolchains, which pass the wrong > version of __FreeBSD__. They should set the value to 13, not 12. > > -Dimitry >