Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Mar 2015 13:44:43 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Jimmy Olgeni <olgeni@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r381910 - in head: deskutils/docear devel/csoap games/xbattle graphics/whirlgif misc/metromap misc/whichman multimedia/smpeg2 net/exabgp net/tableutil sysutils/bontmia sysutils/clonehdd...
Message-ID:  <20150322134443.GA67200@FreeBSD.org>
In-Reply-To: <201503221322.t2MDMrcO094256@svn.freebsd.org>
References:  <201503221322.t2MDMrcO094256@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 22, 2015 at 01:22:53PM +0000, Jimmy Olgeni wrote:
> New Revision: 381910
> URL: https://svnweb.freebsd.org/changeset/ports/381910
> QAT: https://qat.redports.org/buildarchive/r381910/
> 
> Log:
>   Fix minor typos in pkg-descr files.

As usual, thanks for doing this Jimmy!  Few observations, if you permit:

> Modified: head/misc/metromap/pkg-descr
> ==============================================================================
> --- head/misc/metromap/pkg-descr	Sun Mar 22 12:59:46 2015	(r381909)
> +++ head/misc/metromap/pkg-descr	Sun Mar 22 13:22:52 2015	(r381910)
> @@ -1,4 +1,4 @@
> -Metromap is a simple pygtk+2 programm for finding pathes in metro(subway) maps.
> +Metromap is a simple pygtk+2 program for finding paths in metro(subway) maps.
								  ^
Missing space before opening parenthesis.  I suspect there might be few
similar mistakes throughout the tree, so they better be fixed together in
one go, not on per-port basis.

>  Maps for Moscow, St. Petersburg, Kiev, London and Berlin are included.
						^
Missing comma before "and".  While a minor (and arguable) issue, we tend
to respect Oxford comma in FreeBSD.

> ==============================================================================
> --- head/sysutils/clonehdd/pkg-descr	Sun Mar 22 12:59:46 2015	(r381909)
> +++ head/sysutils/clonehdd/pkg-descr	Sun Mar 22 13:22:52 2015	(r381910)
> @@ -1,7 +1,7 @@
>  Tool for copy partitions to another HDD. FreeBSD  stores  its  data  on
> -partitions,  which  incapsulated  in  slices.  Soft,  such as Partition
> +partitions,  which  encapsulated  in  slices.  Soft,  such as Partition
>  Magic, Acronis, etc. detect only slice, not  real  partitions  on  that
> -slice.   CloneHDD  correctly  understand size diference between two HDD
> +slice.   CloneHDD  correctly  understand size difference between two HDD
>  and change size of each partition  proportionally  for  filling  entire
>  HDD.

Wow, this file definitely abuses whitespace way to much. :)

> Modified: head/x11-fonts/croscorefonts-fonts-ttf/pkg-descr
> ==============================================================================
> --- head/x11-fonts/croscorefonts-fonts-ttf/pkg-descr	Sun Mar 22 12:59:46 2015	(r381909)
> +++ head/x11-fonts/croscorefonts-fonts-ttf/pkg-descr	Sun Mar 22 13:22:52 2015	(r381910)
> @@ -1,7 +1,7 @@
>  Google has created a set of fonts for its ChromeOS Operating system.
>  
>  The three standard ones closely mimic the most popular ones for the Windows
> -platform and the linuxso-called Liberation fonts but are available under an
> +platform and the linux so-called Liberation fonts but are available under an

"Linux" should should start with an upper-case letter in this case.
Preceding definite article IMHO should be dropped.

> Modified: head/x11/stjerm/pkg-descr
> ==============================================================================
> --- head/x11/stjerm/pkg-descr	Sun Mar 22 12:59:46 2015	(r381909)
> +++ head/x11/stjerm/pkg-descr	Sun Mar 22 13:22:52 2015	(r381910)
> @@ -1,4 +1,4 @@
> -Stjerm is a quake-like terminal emulator. It's window is shown with a key
> +Stjerm is a quake-like terminal emulator. Its window is shown with a key

Since "quake" refers to the game here, it should start with an upper-case
letter (Quake) as well.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150322134443.GA67200>