From owner-svn-ports-head@freebsd.org  Sun Apr 12 09:20:06 2020
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8A7402B7A79;
 Sun, 12 Apr 2020 09:20:06 +0000 (UTC)
 (envelope-from rene@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 490R6Z3CQkz3NLG;
 Sun, 12 Apr 2020 09:20:06 +0000 (UTC)
 (envelope-from rene@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1185)
 id 4D0542753; Sun, 12 Apr 2020 09:20:06 +0000 (UTC)
Date: Sun, 12 Apr 2020 09:20:06 +0000
From: Rene Ladan <rene@freebsd.org>
To: Matthias Andree <mandree@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r531475 - in head/dns/dnsmasq: . files
Message-ID: <20200412092006.GA28960@freefall.freebsd.org>
References: <202004120216.03C2GAr3064540@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202004120216.03C2GAr3064540@repo.freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Apr 2020 09:20:06 -0000

On Sun, Apr 12, 2020 at 02:16:10AM +0000, Matthias Andree wrote:
> Author: mandree
> Date: Sun Apr 12 02:16:10 2020
> New Revision: 531475
> URL: https://svnweb.freebsd.org/changeset/ports/531475
> 
> Log:
>   dns/dnsmasq: repair damage from UNAUTHORIZED UCL conversion of pkg-message
>   
>   The pkg-message contains a security note that is necessary on
>   new installs and on updates alike.
>   
>   Since per the porter's handbook, the UCL does not support enumeration
>   of types, and this is not relevant on removal, the UCL change must be
>   reverted.  While here, remove formatting.
>   
>   Failure inducing commit:
>   |------------------------------------------------------------------------
>   |r508835 | mat | 2019-08-13 18:01:59 +0200 (Tue, 13 Aug 2019) | 2 lines
>   |
>   |Convert to UCL & cleanup pkg-message (categories d)
>   |
>   |------------------------------------------------------------------------
>   
>   NOTE: The UCL conversion of files/pkg-message.in was not authorized
>   and damaging and no heads-up was sent to the maintainer.
>   
>   portmgr@ MUST act more carefully with sweeping changes and hand them out
>   for review first.
> 
You are clearly missing the bigger picture here, which is to only show users
messages from pkg when they are needed.  pkg-message *does* support showing
messages on both install and update (see section 9.1.1 of
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/pkg-files.html )

This page also notes: "Committers have blanket approval to constrain existing
messages to install or upgrade ranges using the UCL format specifications."

Please revert and fix properly.

René