Date: Wed, 17 Mar 2004 14:32:20 +0100 From: Christophe Prevotaux <c.prevotaux@hexanet.fr> To: David Malone <dwmalone@maths.tcd.ie> Cc: freebsd-net@freebsd.org Subject: Re: PPPoE buglet... Message-ID: <20040317143220.6cd28174.c.prevotaux@hexanet.fr> In-Reply-To: <200403171152.aa43952@salmon.maths.tcd.ie> References: <200403171152.aa43952@salmon.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
Yes please fix it.=20 On Wed, 17 Mar 2004 11:52:53 +0000 David Malone <dwmalone@maths.tcd.ie> wrote: > I spent a while trying to get PPPoE going through a Netopia smart > modem last night. To cut a long story short, the values for > PTT_RELAY_SID in src/sys/netgraph/ng_pppoe.h are wrong (at least > when compared with tcpdump, linux and the RFC). We have: >=20 > #if BYTE_ORDER =3D=3D BIG_ENDIAN > #define PTT_RELAY_SID (0x0106) > #else > #define PTT_RELAY_SID (0x0601) > #endif >=20 > but we should have: >=20 > #if BYTE_ORDER =3D=3D BIG_ENDIAN > #define PTT_RELAY_SID (0x0110) > #else > #define PTT_RELAY_SID (0x1001) > #endif >=20 > Anyone object to my fixing it? The only thing I can think of that > it might break would be people using ng_pppoe as a PPPoE relay with > only ng_pppoe PPPoE clients. >=20 -- =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Christophe Prevotaux Email: c.prevotaux@hexanet.fr HEXANET SARL URL: http://www.hexanet.fr/ Z.A.C Les Charmilles Tel: +33 (0)3 26 79 30 05=20 3 All=E9e Thierry Sabine Direct: +33 (0)3 26 61 77 72=20 BP202 Fax: +33 (0)3 26 79 30 06 51686 Reims Cedex 2 =20 FRANCE HEXANET Network Operation Center =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040317143220.6cd28174.c.prevotaux>