From owner-svn-src-all@freebsd.org Fri Dec 6 16:58:29 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9855C1B0584 for ; Fri, 6 Dec 2019 16:58:29 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47TzLY1Qjwz4ct2 for ; Fri, 6 Dec 2019 16:58:28 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1575651507; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=U5hcPSlJig4htwX3/jdX1pGgKkem9tY1uQxMpPcMlnLzoaBRvM4wCpOtL39WyTuFpE8ymX3uzeyTN lIZAIpU95gk9/pyxgA4LFQ/YMcaJpHS8tdC8Bkb2M0Mo5poyPL1Cy4EHIwaRFGoiEZz3RFAVsiWpn4 3Av+d5caJZeoIhlkuhhlwgeiAHARwu/IbzqGMOVT1oxDdb5itlYMI4iWz6G3vdvhZFODnO6rGQ8ZfV kiPw42U7ML19kAw+zrLHkxeOes1LvRiw4xAwVw4aq/Drgk4GYwpxTnOTE7mbufmhfQ01Pxwq112MuG JKWaS7drIzTGGabUSXyyMsUf1Bw1HAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=Vl+pAJcVPhMg0uQE7O5ZVCUoBTgBUsUjKtUSWdiXqs4=; b=CzZPqkGpD+5MUkQx2/oahKXp4q25SODSYhikREL+4xl+SL53PGWOt/qer2HzmybQ2UO017rs+Wprg cn0rHxVl8ozt2TiFQ6rehDYCMssc83tg6oiMlgm7XhZqNtixkGEUKRkcrs/YG/QI/Z42m8NJ+MYeen bo7LENK8nB52hwLuxGgxg2HcIrUwsm1GqyfTjzsClIWr6gahe0DG7UULOjinEgqNO0+4z9162Plw4m qZpUupVfTCUDnCPg6JZewTs6C4HAC+5NBeQq2UwNKGyWOFBCidVzPZcH70q/DuhSwHVIXXEMwfLNR8 g3kvfHcn5lb/gAmJSZH4WzKc2qiCivg== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=Vl+pAJcVPhMg0uQE7O5ZVCUoBTgBUsUjKtUSWdiXqs4=; b=JGg7zdU9Hn2OXQWBzHm/n/FotI1XoUubWAnr1cOMZ97qgaS8McFyhARX+Q2KSKhlWiaORSlKPW7nJ TgYolAi1RMRHc5QTItpsZxd6bRrIv+hiJuNJBeZY0KT+Q8DJ8n1QPCGZxqreND3hu2fIvAySC6OW9O +17IOuW76e2KzqZPfUYAvRhojNJVQhhEMAw/8Ce+RDykH+K3arecyHAmAQHdN5/GkDuYreSdtAlo6T o74miPtDC5IRV+wh6wc8wpdg83DFAuPYhuVdGEdAYtRdc2aFKeqOyJIWg5OOHCvhjvlxB9Qfp8krWm bsC+fdva4aPbl0TyRobf01JghhqVIsQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: 9defd064-1849-11ea-829e-79a40d15cccd X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 9defd064-1849-11ea-829e-79a40d15cccd; Fri, 06 Dec 2019 16:58:26 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id xB6GwOxw011708; Fri, 6 Dec 2019 09:58:24 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <7160a41739e5b251b50defb44ad08f3c722ea9c7.camel@freebsd.org> Subject: Re: svn commit: r355444 - in head/sys: arm/mv arm64/conf conf From: Ian Lepore To: Luiz Otavio O Souza , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 06 Dec 2019 09:58:24 -0700 In-Reply-To: <201912061255.xB6CtdJw011374@repo.freebsd.org> References: <201912061255.xB6CtdJw011374@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47TzLY1Qjwz4ct2 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.97 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.99)[-0.985,0]; NEURAL_HAM_LONG(-0.98)[-0.980,0]; ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Dec 2019 16:58:29 -0000 On Fri, 2019-12-06 at 12:55 +0000, Luiz Otavio O Souza wrote: > Author: loos > Date: Fri Dec 6 12:55:39 2019 > New Revision: 355444 > URL: https://svnweb.freebsd.org/changeset/base/355444 > > Log: > Add the SPI driver for the Marvell Armada 37x0 SoC. > > Interrupt based driver, implements SPI mode and clock configuration. > > Tested on espressobin and SG-3200. > > Sponsored by: Rubicon Communications, LLC (Netgate) > > Added: > head/sys/arm/mv/a37x0_spi.c (contents, props changed) > Modified: > head/sys/arm64/conf/GENERIC > head/sys/conf/files.arm64 > > Added: head/sys/arm/mv/a37x0_spi.c > > > +static int > +a37x0_spi_detach(device_t dev) > +{ > + struct a37x0_spi_softc *sc; > + > + bus_generic_detach(dev); > It's possible for detaching children to fail (like if one of them returns EBUSY from its detach), in which case you should bail on your detach and return the error status. Also, this needs a device_destroy_children() here after detaching them, to remove the spibus child added in attach (in case the module is unloaded then reloaded, that avoids adding a second copy of the child). -- Ian