From owner-svn-ports-all@freebsd.org Tue Apr 24 16:52:59 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65BE4FABCF5; Tue, 24 Apr 2018 16:52:59 +0000 (UTC) (envelope-from yuri@freebsd.org) Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42]) by mx1.freebsd.org (Postfix) with ESMTP id C22A6763E1; Tue, 24 Apr 2018 16:52:58 +0000 (UTC) (envelope-from yuri@freebsd.org) Received: from yv.noip.me (c-24-4-131-132.hsd1.ca.comcast.net [24.4.131.132]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id w3OGqoam021058 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 24 Apr 2018 09:52:50 -0700 (PDT) (envelope-from yuri@freebsd.org) X-Authentication-Warning: shell1.rawbw.com: Host c-24-4-131-132.hsd1.ca.comcast.net [24.4.131.132] claimed to be yv.noip.me Reply-To: yuri@freebsd.org Subject: Re: svn commit: r468186 - head/databases/sfcgal To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201804240728.w3O7SaRa036534@repo.freebsd.org> <20180424074642.lttispipfbvrg7xy@atuin.in.mat.cc> From: Yuri Message-ID: <0bfe4aa8-5d9d-b625-af2d-f7041d40628c@freebsd.org> Date: Tue, 24 Apr 2018 09:52:49 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180424074642.lttispipfbvrg7xy@atuin.in.mat.cc> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 16:52:59 -0000 On 04/24/18 00:46, Mathieu Arnold wrote: > Because when the major version changes, it will get automagically > changed in the plist, and the maintainer will not think about bumping > all dependent ports. For libraries, committers should always compare headers before and after the update, regardless of whether SONAME changes or not. This is because developers often make big changes in the headers and don't change SONAME accordingly. devel/oniguruma is one example that I've seen, and there were other examples. Only changes that are additions of non-virtual members are okay. Changes in members, their removals, and additions of virtual functions aren't ok. Yuri