From owner-freebsd-ports-bugs@FreeBSD.ORG Sat May 26 22:10:05 2007 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BEB5C16A41F for ; Sat, 26 May 2007 22:10:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 87AE213C447 for ; Sat, 26 May 2007 22:10:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l4QMA5r3092555 for ; Sat, 26 May 2007 22:10:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l4QMA50C092554; Sat, 26 May 2007 22:10:05 GMT (envelope-from gnats) Resent-Date: Sat, 26 May 2007 22:10:05 GMT Resent-Message-Id: <200705262210.l4QMA50C092554@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Marcus von Appen Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B751E16A46B for ; Sat, 26 May 2007 22:04:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [69.147.83.33]) by mx1.freebsd.org (Postfix) with ESMTP id A824113C44B for ; Sat, 26 May 2007 22:04:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l4QM4F3g060871 for ; Sat, 26 May 2007 22:04:15 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id l4QM4FhD060870; Sat, 26 May 2007 22:04:15 GMT (envelope-from nobody) Message-Id: <200705262204.l4QM4FhD060870@www.freebsd.org> Date: Sat, 26 May 2007 22:04:15 GMT From: Marcus von Appen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.0 Cc: Subject: ports/113040: [Patch]: graphics/py-imaging - respect WITHOUT_TKINTER knob X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 May 2007 22:10:05 -0000 >Number: 113040 >Category: ports >Synopsis: [Patch]: graphics/py-imaging - respect WITHOUT_TKINTER knob >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat May 26 22:10:05 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Marcus von Appen >Release: FreeBSD 6.2-STABLE i386 >Organization: >Environment: FreeBSD magenta.linden.home 6.2-STABLE FreeBSD 6.2-STABLE #0: Sat May 26 00:04:44 CEST 2007 root@magenta.linden.home:/usr/obj/usr/src/sys/GENERIC i386 >Description: graphics/py-tkinter does not care about the TKINTER knob in cases where py-tkinter is already installed. The attached patch fixes this by explicitly deactivating the py-tkinter checks in the setup.py of the upstream packege. Bumped PORTREVISION in order to point users to that issue and to allow them to get rid of the superfluous module. Maybe a small note in UPDATING would make sense, so users delete %%PYTHON_SITELIBDIR%%/PIL/_imagingtk.so if they do not use the TKINTER knob. >How-To-Repeat: >Fix: diff -Nur py-imaging/Makefile py-imaging.new/Makefile --- py-imaging/Makefile Sat May 26 23:14:00 2007 +++ py-imaging.new/Makefile Sat May 26 23:29:36 2007 @@ -7,7 +7,7 @@ PORTNAME= imaging PORTVERSION= 1.1.6 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= graphics python MASTER_SITES= http://effbot.org/downloads/ \ http://www.pythonware.net/storage/ @@ -41,6 +41,11 @@ PLIST_SUB+= TKINTER="" .else PLIST_SUB+= TKINTER="@comment " +.endif + +.if defined(WITHOUT_TKINTER) +post-patch: + @${REINPLACE_CMD} -e 's|if _tkinter|if None|g' ${WRKSRC}/setup.py .endif post-install: >Release-Note: >Audit-Trail: >Unformatted: