Date: Fri, 27 Jun 2008 12:33:38 +0900 (JST) From: Tomoyuki Sakurai <cherry@trombik.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: marcus@FreeBSD.org Subject: ports/125037: [PATCH] ports-mgmt/portlint: warn %%PORTDOCS%%%%EXAMPLESDIR%% Message-ID: <20080627033338.807331CD01@spica.trombik.org> Resent-Message-ID: <200806270340.m5R3e1jn035906@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 125037
>Category: ports
>Synopsis: [PATCH] ports-mgmt/portlint: warn %%PORTDOCS%%%%EXAMPLESDIR%%
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Fri Jun 27 03:40:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Tomoyuki Sakurai
>Release: FreeBSD 7.0-STABLE amd64
>Organization:
>Environment:
System: FreeBSD spica.trombik.org 7.0-STABLE FreeBSD 7.0-STABLE #3: Tue Jun 24 08:49:06 JST 2008
>Description:
- warn %%PORTDOCS%%%%EXAMPLESDIR%% and %%PORTDOCS%%%%DATADIR%% in plist
Port maintainer (marcus@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:
--- portlint-2.9.9.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/ports-mgmt/portlint/Makefile /usr/home/cherry/svk/ports/ports-mgmt/portlint/Makefile
--- /usr/ports/ports-mgmt/portlint/Makefile 2008-03-23 09:25:30.000000000 +0900
+++ /usr/home/cherry/svk/ports/ports-mgmt/portlint/Makefile 2008-06-27 12:25:57.000000000 +0900
@@ -8,7 +8,7 @@
#
PORTNAME= portlint
-PORTVERSION= 2.9.8
+PORTVERSION= 2.9.9
CATEGORIES= ports-mgmt
MASTER_SITES= # none
DISTFILES= # none
diff -ruN --exclude=CVS /usr/ports/ports-mgmt/portlint/src/portlint.pl /usr/home/cherry/svk/ports/ports-mgmt/portlint/src/portlint.pl
--- /usr/ports/ports-mgmt/portlint/src/portlint.pl 2008-03-23 09:25:30.000000000 +0900
+++ /usr/home/cherry/svk/ports/ports-mgmt/portlint/src/portlint.pl 2008-06-27 12:25:45.000000000 +0900
@@ -46,7 +46,7 @@
# version variables
my $major = 2;
my $minor = 9;
-my $micro = 8;
+my $micro = 9;
sub l { '[{(]'; }
sub r { '[)}]'; }
@@ -837,6 +837,15 @@
$sharedocused++;
}
+ if ($_ =~ /^\%\%PORTDOCS\%\%.*\%\%DATADIR\%\%/) {
+ &perror("WARN", $file, $., "Wrong pair of variables is used. ".
+ "Use %%PORTDATA%% and %%DATADIR%% instead.");
+ }
+ if ($_ =~ /^\%\%PORTDOCS\%\%.*\%\%EXAMPLESDIR\%\%/) {
+ &perror("WARN", $file, $., "Wrong pair of variables is used. ".
+ "Use %%PORTEXAMPLES%% and %%EXAMPLESDIR%% instead.");
+ }
+
if ($_ =~ /^share\/examples\//) {
&perror("WARN", $file, $., "If and only if your port is ".
"EXAMPLESDIR-safe (that is, a user can override EXAMPLESDIR ".
--- portlint-2.9.9.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080627033338.807331CD01>