Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Aug 2023 15:28:18 GMT
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 8e4aa6317eb8 - main - nctgpio: Enable all the 9 groups for NCT6116D and remove FIXMEs
Message-ID:  <202308041528.374FSI0S026269@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=8e4aa6317eb8145a8a9f6a61e235d13302cd13e3

commit 8e4aa6317eb8145a8a9f6a61e235d13302cd13e3
Author:     Stéphane Rochoy <stephane.rochoy@stormshield.eu>
AuthorDate: 2023-07-04 13:57:08 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-08-04 15:27:54 +0000

    nctgpio: Enable all the 9 groups for NCT6116D and remove FIXMEs
    
    Reviewed by:    emaste
    Pull Request:   https://github.com/freebsd/freebsd-src/pull/810
---
 sys/dev/nctgpio/nctgpio.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/sys/dev/nctgpio/nctgpio.c b/sys/dev/nctgpio/nctgpio.c
index 07208e0fbd90..393553aae227 100644
--- a/sys/dev/nctgpio/nctgpio.c
+++ b/sys/dev/nctgpio/nctgpio.c
@@ -637,7 +637,7 @@ struct nct_device {
 	{
 		.devid   = 0xd282,
 		.descr   = "GPIO on Nuvoton NCT6112D/NCT6114D/NCT6116D",
-		.ngroups = 2,
+		.ngroups = 9,
 		.groups  = {
 			{
 				.grpnum      = 0,
@@ -646,7 +646,7 @@ struct nct_device {
 				.enable_reg  = 0x30,
 				.enable_mask = 0x01,
 				.data_ldn    = 0x07,
-				.ppod_reg    = 0xe0, /* FIXME Need to check for this group. */
+				.ppod_reg    = 0xe0,
 				.caps        = NCT_GPIO_CAPS,
 				.npins       = 8,
 				.iobase      = 0xe0,
@@ -658,7 +658,7 @@ struct nct_device {
 				.enable_reg  = 0x30,
 				.enable_mask = 0x02,
 				.data_ldn    = 0x07,
-				.ppod_reg    = 0xe1, /* FIXME Need to check for this group. */
+				.ppod_reg    = 0xe1,
 				.caps        = NCT_GPIO_CAPS,
 				.npins       = 8,
 				.iobase      = 0xe4,
@@ -670,7 +670,7 @@ struct nct_device {
 				.enable_reg  = 0x30,
 				.enable_mask = 0x04,
 				.data_ldn    = 0x07,
-				.ppod_reg    = 0xe1, /* FIXME Need to check for this group. */
+				.ppod_reg    = 0xe1,
 				.caps        = NCT_GPIO_CAPS,
 				.npins       = 8,
 				.iobase      = 0xe8,
@@ -682,7 +682,7 @@ struct nct_device {
 				.enable_reg  = 0x30,
 				.enable_mask = 0x08,
 				.data_ldn    = 0x07,
-				.ppod_reg    = 0xe1, /* FIXME Need to check for this group. */
+				.ppod_reg    = 0xe1,
 				.caps        = NCT_GPIO_CAPS,
 				.npins       = 8,
 				.iobase      = 0xec,
@@ -694,7 +694,7 @@ struct nct_device {
 				.enable_reg  = 0x30,
 				.enable_mask = 0x10,
 				.data_ldn    = 0x07,
-				.ppod_reg    = 0xe1, /* FIXME Need to check for this group. */
+				.ppod_reg    = 0xe1,
 				.caps        = NCT_GPIO_CAPS,
 				.npins       = 8,
 				.iobase      = 0xf0,
@@ -706,7 +706,7 @@ struct nct_device {
 				.enable_reg  = 0x30,
 				.enable_mask = 0x20,
 				.data_ldn    = 0x07,
-				.ppod_reg    = 0xe1, /* FIXME Need to check for this group. */
+				.ppod_reg    = 0xe1,
 				.caps        = NCT_GPIO_CAPS,
 				.npins       = 8,
 				.iobase      = 0xf4,
@@ -718,7 +718,7 @@ struct nct_device {
 				.enable_reg  = 0x30,
 				.enable_mask = 0x40,
 				.data_ldn    = 0x07,
-				.ppod_reg    = 0xe1, /* FIXME Need to check for this group. */
+				.ppod_reg    = 0xe1,
 				.caps        = NCT_GPIO_CAPS,
 				.npins       = 8,
 				.iobase      = 0xf8,
@@ -730,7 +730,7 @@ struct nct_device {
 				.enable_reg  = 0x30,
 				.enable_mask = 0x80,
 				.data_ldn    = 0x07,
-				.ppod_reg    = 0xe1, /* FIXME Need to check for this group. */
+				.ppod_reg    = 0xe1,
 				.caps        = NCT_GPIO_CAPS,
 				.npins       = 8,
 				.iobase      = 0xfc,
@@ -742,7 +742,7 @@ struct nct_device {
 				.enable_reg  = 0x30,
 				.enable_mask = 0x01,
 				.data_ldn    = 0x09,
-				.ppod_reg    = 0xe1, /* FIXME Need to check for this group. */
+				.ppod_reg    = 0xe1,
 				.caps        = NCT_GPIO_CAPS,
 				.npins       = 8,
 				.iobase      = 0xf0,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308041528.374FSI0S026269>