From owner-svn-src-all@FreeBSD.ORG Mon Feb 2 01:00:15 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2DF0C4D8 for ; Mon, 2 Feb 2015 01:00:15 +0000 (UTC) Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B5F6CD9B for ; Mon, 2 Feb 2015 01:00:14 +0000 (UTC) Received: by mail-wg0-f44.google.com with SMTP id z12so36053105wgg.3 for ; Sun, 01 Feb 2015 17:00:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=gDff3yowCPqdd5FzpNQ0C8o+Fr0u8lzeG/I8Sh3WHow=; b=IA7YPAUVaMyJAH3vzCV3COSOh0n4fX7uFl4FomijWUx34YEfYv+VQ+LIC0BeCnlnEY CCW8i6hEjZGGS1ZRC3fLEqDoINnSkLK15qN5lG3+kV6SSvLEaSoAUpy/GG2rfCv88NHM gWtDfqTF1Tjs+n8ZMXnUEwEnDxtuGdRDwedNpqY0LmB+uHN7kgXjJGuRq5Z2TzI4YNxR N29bYFNHhrdCrTRmJhSscY4mP/aHxzwCJEU9rZbVUdzIhFm1c4nVVgU6sOFo+j/v6/kq cJ70Qbbczrg+Ugbd6ezt4QJrfwD9jEM/dzlfkABhhSRCwno+h6UW7UzQPLgOZccFsK+s izLQ== X-Gm-Message-State: ALoCoQnTB25ROxuc6yb8/hlWbFZA7+yessBHEax3JWo5AzrJ0cr+8pXDwP9rD9q6FUJslZjZiF+p X-Received: by 10.194.170.161 with SMTP id an1mr36500237wjc.126.1422838435803; Sun, 01 Feb 2015 16:53:55 -0800 (PST) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by mx.google.com with ESMTPSA id u9sm25443419wjy.37.2015.02.01.16.53.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Feb 2015 16:53:55 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Message-ID: <54CECAA5.9090406@freebsd.org> Date: Mon, 02 Feb 2015 00:53:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Davide Italiano Subject: Re: svn commit: r278040 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs References: <201502020017.t120Hb2g095087@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Feb 2015 01:00:15 -0000 On 02/02/2015 00:28, Davide Italiano wrote: > On Mon, Feb 2, 2015 at 1:17 AM, Steven Hartland wrote: >> Author: smh >> Date: Mon Feb 2 00:17:36 2015 >> New Revision: 278040 >> URL: https://svnweb.freebsd.org/changeset/base/278040 >> >> Log: >> Prevent inlining txg_quiesce >> >> This allows dtrace to monitor the calls to txg_quiesce which can be really >> helpful. >> >> Also standardise __noinline order for arc_kmem_reap_now. >> >> Sponsored by: Multiplay >> >> > I found this while I was at iXsystems, trying to port Richard Elling's > arc statistics utility to FreeBSD. > I do not disagree with the change in theory, but I never committed > this because I was worried of performance penalty. > Last time I checked Solaris/Illumos actually do not inline this > function without any particular directive (I guess this is mostly due > to difference in toolchain, in particular in the compiler), so it > shouldn't be a big deal, but if you have time, do you mind to check > the penalty introduced, if any, is negligible? Performance difference should be negligible if not unmeasurable, but I'll run some tests to check call frequency to be sure. From what I can tell its inlined because there is only a single caller (txg_quiesce_thread). Regards Steve