From owner-cvs-all Sat Nov 2 4:11:10 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A91BE37B404; Sat, 2 Nov 2002 04:11:08 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id DFC6F43E4A; Sat, 2 Nov 2002 04:11:07 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id gA2CB29d020452; Sat, 2 Nov 2002 13:11:03 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Marcel Moolenaar Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom geom_mbr.c In-Reply-To: Your message of "Sat, 02 Nov 2002 04:01:12 PST." <200211021201.gA2C1CKD025754@repoman.freebsd.org> Date: Sat, 02 Nov 2002 13:11:02 +0100 Message-ID: <20451.1036239062@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200211021201.gA2C1CKD025754@repoman.freebsd.org>, Marcel Moolenaar writes: >marcel 2002/11/02 04:01:12 PST > > Modified files: > sys/geom geom_mbr.c > Log: > Remove the GEOM_GPT hack. We now check for partition type 0xEE and > skip those. This handles the Protective MBR (PMBR) which consists > of a single partition of type 0xEE that covers the whole disk and > as such protects the GPT partitioning. We allow other partitions to > be present besides partitions of type 0xEE and as such interpret > partition type 0xEE as a "hands-off" partition only. > > While here, fix g_mbrext_dumpconf to test if indent is NULL and > dump the data in a form that libdisk can grok. Change the logic > in g_mbr_dumpconf to match that of g_mbrext_dumpconf. This does > not change the output, but prevents a NULL-pointer dereference > when indent == NULL && pp == NULL. Thanks! I had overlooked that one. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message