From owner-freebsd-net@freebsd.org Sat Feb 10 01:57:27 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E6B19F15A81 for ; Sat, 10 Feb 2018 01:57:26 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-qk0-x231.google.com (mail-qk0-x231.google.com [IPv6:2607:f8b0:400d:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7D96D85DBC for ; Sat, 10 Feb 2018 01:57:26 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-qk0-x231.google.com with SMTP id c82so12348599qka.0 for ; Fri, 09 Feb 2018 17:57:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=1e4NS67yiaRyWtii2/lYvlAf1BZpn/GKu2z6PbkLWBE=; b=s4N83wY8ph/+Zt8uWQhOyu+vXhUs+hZ/dBKtTtTOq2LR1IAOeWPsz5unydvVtXS2uP ivIb9pnfhpYmiO47q2fA3jzZQediB+Q0PsRTMsuwbK8MNRgjhbF0N4Ql6n8FHJ3Vk6pO IZq1nm/4+/Z5VzZUNm3Ck4eLNYwZK6YFyNG6BjbCEq5+OogTOC4hjuksvy9Y1YbGfkSX QDgXar7rchXCzHB7qCqDHhsvqTCjKe3kijuoULN400265Pr8kdOTI4p0pA0GY6s2MzYF yVUIHDrd7oDPKKhtqTl3K+duUfaKjIVMknj2kaupAb82KHknCdcpoHOipWKfN4kmNbpF 3afg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=1e4NS67yiaRyWtii2/lYvlAf1BZpn/GKu2z6PbkLWBE=; b=PuG3Kz1+C22c6Rn9I6rBObDiL8/lXJwv0ZF1F/WGCuNXxtUq5gxxcs8ARnWcE9S4D7 QQJgO+s+q2lRFCC0/DfcDGCbFB64YTX82SYVSVh4Lt39pm6YZO1k3Q+EFvY+gPDc0NsH 9VLfVLoAEoQepInnXPELxGBA1U63eeGtoqr1qIdqNB9HsB7MmnmCzVnRI9jVgRAwNjVb DoHn7FXOL+IN57Ov0coe1rFk/RrZdyI5SA3i4qsMrHV5Ne8pmt5ae48JaGzaisuVt40X w3YIcTefidyJ6eMkGnnU/9ZB3p662amwFqr38Vueq9gUurfNrk//+MND2QLAtGfwsq1C x1Xw== X-Gm-Message-State: APf1xPCUSZ9Db+r6QFXlGGfZH+tNrIgRkspeRp8Q8lo4mC7cJl4OAAaA RT+Hm7aByFpWHiqxKD3PZzHnNBOsa2FAV9pXtkSKOg== X-Google-Smtp-Source: AH8x226OO7FX59p1JFkYPMIi0/xwtqzV/mLrl2xTYeX83N5oPlq8Xb6HWWnF2uzTaiYZuvXi5RQu5WDrI4je1WjzRJE= X-Received: by 10.55.102.6 with SMTP id a6mr6718705qkc.160.1518227845716; Fri, 09 Feb 2018 17:57:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.50.228 with HTTP; Fri, 9 Feb 2018 17:57:25 -0800 (PST) From: Ryan Stone Date: Fri, 9 Feb 2018 20:57:25 -0500 Message-ID: Subject: Review: Fix regression that did not allow "route change" that didn't re-specify the gateway To: freebsd-net Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Feb 2018 01:57:27 -0000 A change a while back (r264986) broke the ability to change a route's parameters if the gateway wasn't explicitly specified again. For example, you used to be able to run "route change 10.0.0.0/8 -mtu 9000" to change the MTU without having to provide the gateway IP to the command. I have a review open to restore the existing behaviour. In cases where the gateway is not specified, the gateway on the route remains unchanged. Anyone interested in reviewing this change should add themselves as a reviewer to https://reviews.freebsd.org/D14291. Thanks, Ryan