From owner-freebsd-hackers@FreeBSD.ORG  Sun Mar 14 12:12:19 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 24E1F106566C;
	Sun, 14 Mar 2010 12:12:18 +0000 (UTC)
	(envelope-from a_best01@uni-muenster.de)
Received: from zivm-relay3.uni-muenster.de (ZIVM-RELAY3.UNI-MUENSTER.DE
	[128.176.192.19])
	by mx1.freebsd.org (Postfix) with ESMTP id 49B6F8FC1D;
	Sun, 14 Mar 2010 12:12:17 +0000 (UTC)
X-IronPort-AV: E=Sophos;i="4.49,638,1262559600"; d="scan'208";a="28366988"
Received: from zivmaildisp1.uni-muenster.de (HELO
	ZIVMAILUSER04.UNI-MUENSTER.DE) ([128.176.188.85])
	by zivm-relay3.uni-muenster.de with ESMTP; 14 Mar 2010 13:12:15 +0100
Received: by ZIVMAILUSER04.UNI-MUENSTER.DE (Postfix, from userid 149459)
	id 76B7C1B07C1; Sun, 14 Mar 2010 13:12:15 +0100 (CET)
Date: Sun, 14 Mar 2010 13:12:14 +0100 (CET)
From: Alexander Best <alexbestms@wwu.de>
Sender: <a_best01@uni-muenster.de>
Organization: Westfaelische Wilhelms-Universitaet Muenster
To: Garrett Cooper <yanefbsd@gmail.com>
Message-ID: <permail-2010031412121480e26a0b00003ff3-a_best01@message-id.uni-muenster.de>
In-Reply-To: <7d6fde3d1003132155t3059a438m80bd50fdf1dbe091@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@freebsd.org, Doug Barton <dougb@freebsd.org>
Subject: Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Mar 2010 12:12:19 -0000

Garrett Cooper schrieb am 2010-03-14:
> On Sat, Mar 13, 2010 at 9:24 PM, Doug Barton <dougb@freebsd.org>
> wrote:
> > On 03/13/10 05:52, Alexander Best wrote:
> >> hello,

> >> this patch fixes the following gcc warning:

> > For all such issues, please file a PR first so it doesn't get lost.
> > When
> > you get the PR confirmation back, feel free to alert the list to
> > its
> > existence.

>    Yes, please submit a proper PR for this because it's a code bug;
> FYI, your solution isn't complete though (it's close):

ah ok. thanks for the hint. just wanted to spare linimon from dealing with
such minor prs. ;)

> ABORT(3)               FreeBSD Library Functions Manual
> ABORT(3)

> NAME
>      abort -- cause abnormal program termination

> LIBRARY
>      Standard C Library (libc, -lc)

> SYNOPSIS
>      #include <stdlib.h>

>      void
>      abort(void);

>     Please be explicit and add stdlib.h.

adding stdlib.h isn't going to work since stand.h is used to declare function
prototypes which are also in stdlib.h. adding stdlib.h will cause gcc to
complain about multiple definitions. stand.h e.g. has it's own printf and some
other stuff.

cheers.
alex

> Thanks,
> -Garrett