Date: Wed, 24 Apr 2013 20:30:57 +0100 From: Chris Rees <crees@FreeBSD.org> To: Jung-uk Kim <jkim@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, svn-ports-all@freebsd.org, Jimmy Olgeni <olgeni@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r316469 - head/databases/slony1v2 Message-ID: <CADLo83_VLFq4kZ683u9e63T-mfF5am1-MGbFR3K4kV6L5TviQQ@mail.gmail.com> In-Reply-To: <517830D2.5060600@FreeBSD.org> References: <201304241850.r3OIovPc079999@svn.freebsd.org> <51782B87.2090000@FreeBSD.org> <alpine.BSF.2.00.1304242105250.29749@olgeni.olgeni> <517830D2.5060600@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24 April 2013 20:21, Jung-uk Kim <jkim@freebsd.org> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 2013-04-24 15:08:00 -0400, Jimmy Olgeni wrote: >> >> On Wed, 24 Apr 2013, Jung-uk Kim wrote: >> >>> On 2013-04-24 14:50:57 -0400, Jimmy Olgeni wrote: >>>> Author: olgeni Date: Wed Apr 24 18:50:57 2013 New Revision: >>>> 316469 URL: http://svnweb.freebsd.org/changeset/ports/316469 >>>> >>>> Log: - Use bsd.port.options.mk. - PORTDOCS should not be >>>> conditional. - Whitespace fix. >>> ... >>> >>> bsd.port.mk says "(PORTDOCS) should not be set when no >>> documentation files are installed" and I believe it is actually >>> correct. >> >> I found this on the Porter's Handbook: >> >> If a directory is listed in PORTDOCS or matched by a glob pattern >> from this variable, the entire subtree of contained files and >> directories will be registered in the final packing list. If the >> DOCS option has been unset then files and directories listed in >> PORTDOCS would not be installed or added to port packing list. >> >> It seems to behave correctly, at least in the PORTDOCS=* case. > > It may work for now because bsd.options.mk has backward compat shim, i.e., > > ## Now some compatibility > .if empty(PORT_OPTIONS:MDOCS) > NOPORTDOCS= yes > .endif > > It won't work when we deprecate the compat shims. Yes, bsd.port.mk needs fixing there. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83_VLFq4kZ683u9e63T-mfF5am1-MGbFR3K4kV6L5TviQQ>