Date: Fri, 20 Jan 2012 18:41:13 -0800 From: Rui Paulo <rpaulo@FreeBSD.org> To: Adrian Chadd <adrian@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230408 - head/sys/net80211 Message-ID: <F190251F-A479-43DD-990C-64FDB501162F@FreeBSD.org> In-Reply-To: <201201210038.q0L0cJac066145@svn.freebsd.org> References: <201201210038.q0L0cJac066145@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012/01/20, at 16:38, Adrian Chadd wrote: > Author: adrian > Date: Sat Jan 21 00:38:18 2012 > New Revision: 230408 > URL: http://svn.freebsd.org/changeset/base/230408 >=20 > Log: > Change the hwmp debugging to use %6D rather than ether_sprintf(). >=20 > This allows for multiple MAC addresses to be printed on the same > debugging line. ether_sprintf() uses a static char buffer and > thus isn't very useful here. >=20 > Submitted by: Monthadar Al Jaberi <monthadar@gmail.com> This commit doesn't help much and keeps us more toolchain dependent like = Alexander pointed out in IRC. Since ether_sprintf() wasn't causing any = trouble, please consider backing this out. This commit also introduces unnecessary changes which make reviewing = harder. Regards, -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F190251F-A479-43DD-990C-64FDB501162F>