From owner-svn-src-all@FreeBSD.ORG Sat Jan 21 02:41:14 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B194A106564A; Sat, 21 Jan 2012 02:41:14 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from felyko.com (stark.strangled.net [IPv6:2607:f2f8:a528::3:1337:ca7]) by mx1.freebsd.org (Postfix) with ESMTP id 98A988FC19; Sat, 21 Jan 2012 02:41:14 +0000 (UTC) Received: from [66.109.103.71] (unknown [66.109.103.71]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by felyko.com (Postfix) with ESMTPSA id AE8493981E; Fri, 20 Jan 2012 18:41:13 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v1256.1) Content-Type: text/plain; charset=us-ascii From: Rui Paulo In-Reply-To: <201201210038.q0L0cJac066145@svn.freebsd.org> Date: Fri, 20 Jan 2012 18:41:13 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201201210038.q0L0cJac066145@svn.freebsd.org> To: Adrian Chadd X-Mailer: Apple Mail (2.1256.1) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230408 - head/sys/net80211 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jan 2012 02:41:14 -0000 On 2012/01/20, at 16:38, Adrian Chadd wrote: > Author: adrian > Date: Sat Jan 21 00:38:18 2012 > New Revision: 230408 > URL: http://svn.freebsd.org/changeset/base/230408 >=20 > Log: > Change the hwmp debugging to use %6D rather than ether_sprintf(). >=20 > This allows for multiple MAC addresses to be printed on the same > debugging line. ether_sprintf() uses a static char buffer and > thus isn't very useful here. >=20 > Submitted by: Monthadar Al Jaberi This commit doesn't help much and keeps us more toolchain dependent like = Alexander pointed out in IRC. Since ether_sprintf() wasn't causing any = trouble, please consider backing this out. This commit also introduces unnecessary changes which make reviewing = harder. Regards, -- Rui Paulo