From owner-svn-ports-head@FreeBSD.ORG Wed Apr 24 19:31:28 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 6631FB36; Wed, 24 Apr 2013 19:31:28 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ia0-x234.google.com (mail-ia0-x234.google.com [IPv6:2607:f8b0:4001:c02::234]) by mx1.freebsd.org (Postfix) with ESMTP id 14C1C1911; Wed, 24 Apr 2013 19:31:28 +0000 (UTC) Received: by mail-ia0-f180.google.com with SMTP id t4so985075iag.25 for ; Wed, 24 Apr 2013 12:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=K13GunKN94pBpllEAHIZ6JzHXShqVt73xIAsx0kGss8=; b=VCij2gySJsFqjvuvXv1LaJC5Gm+d8Dw9BtMP+zPTaKVB+dLkFehAbjlLyi8PGZuqSF 0OHF1GokzMt2JGkTv6dqf4qaFFi+o0EslMX0VE1lxImKDnjWBvz/HmOgROMWchQIdMS2 Iw3LiEfrBE34fpeeJY3XgkenFvKtFvpXMCZ8o2PUsP78Y1riIcHaNCKtx36w7YiRXzAF MJPfoLb4wneGTID4DdMr1Yqdc+DZFvz+aF88lpsa+QVsOJok0L8K0yNYwWA14/XZpQ2x WL+khms1uHZeAsYqtWPrYyJfgQoUeozTtehMzcSwv5lzkFXIMdTmAnIUarCWipMA2XPR gMtw== X-Received: by 10.43.47.5 with SMTP id uq5mr19702443icb.0.1366831887810; Wed, 24 Apr 2013 12:31:27 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.64.58.52 with HTTP; Wed, 24 Apr 2013 12:30:57 -0700 (PDT) In-Reply-To: <517830D2.5060600@FreeBSD.org> References: <201304241850.r3OIovPc079999@svn.freebsd.org> <51782B87.2090000@FreeBSD.org> <517830D2.5060600@FreeBSD.org> From: Chris Rees Date: Wed, 24 Apr 2013 20:30:57 +0100 X-Google-Sender-Auth: _PAzsuxBQzAAqQrF3Ulz7w8Ac2g Message-ID: Subject: Re: svn commit: r316469 - head/databases/slony1v2 To: Jung-uk Kim Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-ports-head@freebsd.org" , svn-ports-all@freebsd.org, Jimmy Olgeni , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2013 19:31:28 -0000 On 24 April 2013 20:21, Jung-uk Kim wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 2013-04-24 15:08:00 -0400, Jimmy Olgeni wrote: >> >> On Wed, 24 Apr 2013, Jung-uk Kim wrote: >> >>> On 2013-04-24 14:50:57 -0400, Jimmy Olgeni wrote: >>>> Author: olgeni Date: Wed Apr 24 18:50:57 2013 New Revision: >>>> 316469 URL: http://svnweb.freebsd.org/changeset/ports/316469 >>>> >>>> Log: - Use bsd.port.options.mk. - PORTDOCS should not be >>>> conditional. - Whitespace fix. >>> ... >>> >>> bsd.port.mk says "(PORTDOCS) should not be set when no >>> documentation files are installed" and I believe it is actually >>> correct. >> >> I found this on the Porter's Handbook: >> >> If a directory is listed in PORTDOCS or matched by a glob pattern >> from this variable, the entire subtree of contained files and >> directories will be registered in the final packing list. If the >> DOCS option has been unset then files and directories listed in >> PORTDOCS would not be installed or added to port packing list. >> >> It seems to behave correctly, at least in the PORTDOCS=* case. > > It may work for now because bsd.options.mk has backward compat shim, i.e., > > ## Now some compatibility > .if empty(PORT_OPTIONS:MDOCS) > NOPORTDOCS= yes > .endif > > It won't work when we deprecate the compat shims. Yes, bsd.port.mk needs fixing there. Chris