From owner-freebsd-current@FreeBSD.ORG Mon Jul 9 04:15:45 2012 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 997B5106566B for ; Mon, 9 Jul 2012 04:15:45 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from opti.dougb.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id D437814E3B9; Mon, 9 Jul 2012 04:15:44 +0000 (UTC) Message-ID: <4FFA5AF0.607@FreeBSD.org> Date: Sun, 08 Jul 2012 21:15:44 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:13.0) Gecko/20120624 Thunderbird/13.0.1 MIME-Version: 1.0 To: George Neville-Neil References: <86hatodavd.wl%gnn@neville-neil.com> <1341340703.6639@da3m0n8t3r.com> <20120704194917.GA15426@misty.eyesbeyond.com> <2244ACD7-892A-4CA7-90B1-FFF41AF6B317@FreeBSD.org> <49BAAAB5-BF68-43B3-8D7C-B4E49DE29ED3@neville-neil.com> <4FFA4454.5070803@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.4.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Greg Lewis , Waitman Gobble , current@FreeBSD.org Subject: Re: Java and NIO? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 04:15:45 -0000 On 07/08/2012 20:01, George Neville-Neil wrote: > > On Jul 8, 2012, at 22:39 , Doug Barton wrote: > >> On 07/08/2012 19:33, George Neville-Neil wrote: >>> A followup. zookeeper is now ported to Freebsd (/usr/ports/devel/zookeeper) >> >> George, did you see the PR and the followup from me regarding the port? >> > > I got a mail from jgh@ but only today figured out what the PR was. Are you not getting your gnn@FreeBSD.org mail? > I'll look at the patches from him tomorrow. I copied the text from my message below for your convenience. > http://www.freebsd.org/cgi/query-pr.cgi?pr=169693 Furthermore the rc.d script is a mess, and should not have been committed like it was (numerous missing bits, bad format, set_rcvar, hard-coded /usr/local, no REQUIRE, no KEYWORD: shutdown, etc.). Please read http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html and then ask in freebsd-rc@ if you have any additional questions. Sorry to be so blunt, but I'm really, really tired of repeating the same stuff over and over again, and this script is really a mess. Also, don't install the script in do-install, see the web page above (and/or the PR) for USE_RC_SUBR. And FYI, there is no need to have the function in that script. You could use (for example) start_cmd="$command start" just as well. Not to mention that the function you have should be using $1 as the argument to $command, not $rc_arg. Reasons why left as an exercise for the reader ... Doug -- This .signature sanitized for your protection