Date: Sun, 08 Jul 2012 21:15:44 -0700 From: Doug Barton <dougb@FreeBSD.org> To: George Neville-Neil <gnn@neville-neil.com> Cc: Greg Lewis <glewis@eyesbeyond.com>, Waitman Gobble <uzimac@da3m0n8t3r.com>, current@FreeBSD.org Subject: Re: Java and NIO? Message-ID: <4FFA5AF0.607@FreeBSD.org> In-Reply-To: <A74185BD-C150-429D-981E-D9B2C83E283E@neville-neil.com> References: <86hatodavd.wl%gnn@neville-neil.com> <1341340703.6639@da3m0n8t3r.com> <20120704194917.GA15426@misty.eyesbeyond.com> <2244ACD7-892A-4CA7-90B1-FFF41AF6B317@FreeBSD.org> <49BAAAB5-BF68-43B3-8D7C-B4E49DE29ED3@neville-neil.com> <4FFA4454.5070803@FreeBSD.org> <A74185BD-C150-429D-981E-D9B2C83E283E@neville-neil.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/08/2012 20:01, George Neville-Neil wrote: > > On Jul 8, 2012, at 22:39 , Doug Barton wrote: > >> On 07/08/2012 19:33, George Neville-Neil wrote: >>> A followup. zookeeper is now ported to Freebsd (/usr/ports/devel/zookeeper) >> >> George, did you see the PR and the followup from me regarding the port? >> > > I got a mail from jgh@ but only today figured out what the PR was. Are you not getting your gnn@FreeBSD.org mail? > I'll look at the patches from him tomorrow. I copied the text from my message below for your convenience. > http://www.freebsd.org/cgi/query-pr.cgi?pr=169693 Furthermore the rc.d script is a mess, and should not have been committed like it was (numerous missing bits, bad format, set_rcvar, hard-coded /usr/local, no REQUIRE, no KEYWORD: shutdown, etc.). Please read http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html and then ask in freebsd-rc@ if you have any additional questions. Sorry to be so blunt, but I'm really, really tired of repeating the same stuff over and over again, and this script is really a mess. Also, don't install the script in do-install, see the web page above (and/or the PR) for USE_RC_SUBR. And FYI, there is no need to have the function in that script. You could use (for example) start_cmd="$command start" just as well. Not to mention that the function you have should be using $1 as the argument to $command, not $rc_arg. Reasons why left as an exercise for the reader ... Doug -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FFA5AF0.607>