From owner-freebsd-ports@FreeBSD.ORG Sun Jun 26 08:16:27 2011 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD3861065672; Sun, 26 Jun 2011 08:16:27 +0000 (UTC) (envelope-from micro@heavennet.ru) Received: from mail-fx0-f44.google.com (mail-fx0-f44.google.com [209.85.161.44]) by mx1.freebsd.org (Postfix) with ESMTP id 809518FC14; Sun, 26 Jun 2011 08:16:26 +0000 (UTC) Received: by fxe6 with SMTP id 6so793375fxe.17 for ; Sun, 26 Jun 2011 01:16:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.5.212 with SMTP id 20mr7131637faw.40.1309076184377; Sun, 26 Jun 2011 01:16:24 -0700 (PDT) Received: by 10.223.109.202 with HTTP; Sun, 26 Jun 2011 01:16:24 -0700 (PDT) In-Reply-To: References: <20110622020048.GA83940@FreeBSD.org> <20110622064224.GB94185@FreeBSD.org> <20110622160233.8b6156e1.itetcu@FreeBSD.org> <20110622135941.GA99725@FreeBSD.org> <20110623033052.GA23118@FreeBSD.org> <20110623083351.GA51681@FreeBSD.org> <4E052ADA.8050200@freebsd.org> Date: Sun, 26 Jun 2011 12:16:24 +0400 Message-ID: From: "Ilya A. Arkhipov" To: Joe Marcus Clarke Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Chris Rees , ports@freebsd.org, Alexey Dokuchaev , Ion-Mihai Tetcu , kwm@freebsd.org Subject: Re: portlint(1) knobs order: let's make things more logical X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jun 2011 08:16:27 -0000 25 =C9=C0=CE=D1 2011 =C7. 15:52 =D0=CF=CC=D8=DA=CF=D7=C1=D4=C5=CC=D8 Ilya A= . Arkhipov =CE=C1=D0=C9=D3=C1=CC: > > > 25 =C9=C0=CE=D1 2011 =C7. 4:24 =D0=CF=CC=D8=DA=CF=D7=C1=D4=C5=CC=D8 Joe M= arcus Clarke =CE=C1=D0=C9=D3=C1=CC: > > On 6/24/11 8:16 AM, Ilya A. Arkhipov wrote: >> > 23 =C9=C0=CE=D1 2011 =C7. 21:52 =D0=CF=CC=D8=DA=CF=D7=C1=D4=C5=CC=D8 I= lya A. Arkhipov > >=CE=C1=D0=C9=D3=C1=CC: >> > >> >> =F3=F3: to eitan@eitanadler.com >> > >> > >> > Hi danfe@, marcus@ and all >> > >> > What you say about this patch(in attach)? >> > >> > ps. sorry i can't test patch on my work >> >> Thanks. Can you submit this as a PR so I can track it. I have a >> portlint commit coming up soon. >> >> Joe >> >> -- >> Joe Marcus Clarke >> FreeBSD GNOME Team :: gnome@FreeBSD.org >> FreeNode / #freebsd-gnome >> http://www.FreeBSD.org/gnome >> > > All patch have error's... > if we use "&checkorder('LICENSE', $tmp, $file," that this block invariabl= e, > but there is no license at all. > Also if try: > print "OK: checking fourth section of $file (LICENSE).\n" > if ($verbose); > $tmp =3D $sections[$idx]; > > if ($tmp =3D~ /LICENSE/) { > > &checkorder('LICENSE', $tmp, $file, qw( > LICENSE LICENSE_COMB LICENSE_GROUPS LICENSE_NAME > > LICENSE_TEXT LICENSE_FILE LICENSE_PERMS > )); > $tmp may not contain license example: > 13 MAINTAINER=3D ports@FreeBSD.org > 14 COMMENT=3D Versatile softsynth implemented as a DSSI plugin > 15 > 16 BUILD_DEPENDS=3D ${LOCALBASE}/include/dssi.h:${PORTSDIR}/audio/dssi= \ > 17 ${LOCALBASE}/include/ladspa.h:${PORTSDIR}/audio/ladspa > 18 LIB_DEPENDS=3D dssialsacompat.0:${PORTSDIR}/audio/libdssialsacomp= at \ > 19 lo.7:${PORTSDIR}/audio/liblo \ > 20 jack.0:${PORTSDIR}/audio/jack \ > 21 fftw3f.5:${PORTSDIR}/math/fftw3-float > 22 > 23 LICENSE=3D GPLv2 LGPL21 > > Any ideas.. > > > -- > Best regards. > Ilya A. Arkhipov > > Hi All, Please test this patch http://micro.heavennet.ru/ports/portlint/portlint.patch --=20 Best regards. Ilya A. Arkhipov