From owner-svn-src-all@FreeBSD.ORG Fri Aug 16 18:55:39 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5C871D70 for ; Fri, 16 Aug 2013 18:55:39 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: from mail-qa0-f44.google.com (mail-qa0-f44.google.com [209.85.216.44]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1E8D32AD5 for ; Fri, 16 Aug 2013 18:55:38 +0000 (UTC) Received: by mail-qa0-f44.google.com with SMTP id hu16so677381qab.10 for ; Fri, 16 Aug 2013 11:55:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=/DWTpDmy1JmIz5SH6KxxnGrCodCYYl6FdBdq55lIMy0=; b=BZXP2JHc/lhHBWfq8A3rkdF/c4RGse7hMUXkcy/ova/BLPnPAcjg0rTtOFtxnnFWoO E+6hfuB10VKsKdCym/Yo3x1Zw7ysIQVJWIongAjtZrT76AJ3zR74l45c1wPGUh4ZgfQz Uav/Fadql4itDBY2XdK7mel+Oim/JbYVjJBPuPXJXrkPDz77A5Lk4a9CNl/mQnvkzfMb Grx3tjDfeTs16pzo/legRpiy83b0WzOrwVkJG2Dz1fVikJvKcwRmefmN8lntFGOX7MM1 3X4dJOqHcpfuAPFBo4SRtstO6MU8q5NJEF84HYWj8vwqu35R3qrIz1reCH7R+6sYnoON 9rvA== X-Gm-Message-State: ALoCoQme2ssN3ZikSoK/puri95xUHDZIrkufEWc11dF+LurmJUSieHjX+R1HPD1ovkNxij+iEEWa MIME-Version: 1.0 X-Received: by 10.49.119.161 with SMTP id kv1mr3782458qeb.25.1376679332158; Fri, 16 Aug 2013 11:55:32 -0700 (PDT) Received: by 10.49.82.34 with HTTP; Fri, 16 Aug 2013 11:55:32 -0700 (PDT) In-Reply-To: <201308161422.r7GEMLWE006753@svn.freebsd.org> References: <201308161422.r7GEMLWE006753@svn.freebsd.org> Date: Fri, 16 Aug 2013 20:55:32 +0200 Message-ID: Subject: Re: svn commit: r254415 - in head/sys: dev/streams fs/devfs kern sys From: Zbigniew Bodek To: Konstantin Belousov Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2013 18:55:39 -0000 2013/8/16 Konstantin Belousov > Author: kib > Date: Fri Aug 16 14:22:20 2013 > New Revision: 254415 > URL: http://svnweb.freebsd.org/changeset/base/254415 > > Log: > Restore the previous sendfile(2) behaviour on the block devices. > Provide valid .fo_sendfile method for several missed struct fileops. > > Reviewed by: glebius > Sponsored by: The FreeBSD Foundation > > Modified: > head/sys/dev/streams/streams.c > head/sys/fs/devfs/devfs_vnops.c > head/sys/kern/sys_procdesc.c > head/sys/kern/vfs_vnops.c > head/sys/sys/file.h > > Hello Konstantin. I believe that this commit adds redundant vn_sendfile declaration. Please see below: c1: warnings being treated as errors sys/kern/uipc_syscalls.c:161: warning: redundant redeclaration of 'vn_sendfile' [-Wredundant-decls] sys/sys/file.h:244: warning: previous declaration of 'vn_sendfile' was here Best regards Zbyszek Bodek