From owner-freebsd-current@freebsd.org Mon Jan 4 18:52:45 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D8B484C0AF1 for ; Mon, 4 Jan 2021 18:52:45 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D8lB42gxlz3kNN; Mon, 4 Jan 2021 18:52:44 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pj1-x1033.google.com with SMTP id m5so138204pjv.5; Mon, 04 Jan 2021 10:52:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=IsP08P7zdaahBA9HvBGNOD3hzlcb5ZLPq+WL87G+kpo=; b=FW9FeZZpjSWehC7kJWhZcSwYqNJ7z3Q+6QJlmItMSKDWiJgnaGWheqX3cMdCOQerUg 4ZtDj35lqVLexauoBmABEMDsgsUDk1ZZFzun5+PpPWlF8ZJgAFA2/JUlH0De4ZhT4SUd djhK7X1bYiCANf9HlWOu6Q2GA6nWsa8wrs+96FRLinu2VrY/XH4VQVxt9RbUi4V2l9tb iDOo0sNrUh4+30EXQpRJZIpPd6MtOj7BQVaqtkvQQflDCgqPxWOXNHGjr+fvk+q76xj6 tMH/hYzqRwi60rg9V3Cf93gjfXTT0vd/zTFNS/zT5nOZ3CYJbZI1OjuRVUZQtmmP9Rbr 90Fw== X-Gm-Message-State: AOAM530qcr/bkpj5/vbImBbr/75Tz3lznX0aFEc5cwTniGHVTSlbC7nC o15NWtpfzS45KC9ibgcNRjmzmw0s8m1uBg== X-Google-Smtp-Source: ABdhPJwcKfkBUE8f4iXUCyKUAW86Yf1W1kWyzyXvi+2s7OnOlK0BKkWFsctyVCP+9siD7GvD1wpHWw== X-Received: by 2002:a17:90a:664c:: with SMTP id f12mr262557pjm.94.1609786362391; Mon, 04 Jan 2021 10:52:42 -0800 (PST) Received: from [192.168.20.29] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id x15sm54602531pfn.118.2021.01.04.10.52.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jan 2021 10:52:41 -0800 (PST) From: Enji Cooper Message-Id: <7E3C7B7F-A127-45DE-A4B2-8C42F707E5D2@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git non-time-sequential logs Date: Mon, 4 Jan 2021 10:52:40 -0800 In-Reply-To: Cc: Poul-Henning Kamp , John Kennedy , Current FreeBSD To: Alan Somers References: <94447.1609779520@critter.freebsd.dk> X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4D8lB42gxlz3kNN X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RECEIVED_SPAMHAUS_PBL(0.00)[73.19.52.228:received]; FROM_EQ_ENVFROM(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::1033:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::1033:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::1033:from]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-current] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2021 18:52:45 -0000 > On Jan 4, 2021, at 9:05 AM, Alan Somers wrote: >=20 > On Mon, Jan 4, 2021 at 9:58 AM Poul-Henning Kamp > wrote: >=20 >> -------- >> John Kennedy writes: >>=20 >>> This might be perfectly natural and just new to me, but when I look = at >> the >>> git logs this morning I see things like this (editing by me): >>>=20 >>> Date: Mon Jan 4 17:30:00 2021 +0100 >>> Date: Mon Dec 14 18:56:56 2020 +0100 >>> Date: Tue Dec 15 13:50:00 2020 +0100 >>> Date: Mon Jan 4 16:23:10 2021 +0100 >>>=20 >>> I've always assumed that the "Date:" there was when the commit >> happened, >>=20 >> It is, but it is the time it was committed in the first git repos it = was >> committed to, >> in this case the repos of the committer in question. >>=20 >> Without taking a position on the merits of this design-choice, I >> just want to point out that it means that timestamps should be >> viewed very sceptically, since they depend on the *local* clock on >> somebodys computer, not on the central repos machine. >>=20 >=20 > I'll be more frank than phk: it sucks. Git's commit dates are = basically > useless. But there are a few ways to improve the situation: > 1) If we start using Gitlab or something similar, we can ban pushes > directly to head. Then we'll be able to trust the Dates on Gitlab's = merge > commits. > 2) Perhaps we can use the Git Notes to add a field for the Date when a > commit was pushed to the master server? > 3) The internet is full of suggestions for how to change the way = commits > are displayed locally to mediate this problem. But they all seem to > involve changes to the working copy's configuration, not the master's. = And > I haven't gotten any way to work. I actually find the non-sequential dates a feature: if someone reorders = commits in a stack, e.g., `git rebase -I` I find it curious wondering = why things were committed in the order they were. The point is to stop looking at git like svn: commits should be done as = larger bodies of work (merge commits), as opposed to single atomic = commits. Cheers, -Enji=