Date: Wed, 20 Jul 2016 21:02:24 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-geom@FreeBSD.org Subject: [Bug 209113] Heap overflow in geom ioctl handler Message-ID: <bug-209113-14739-ot1FAojYV4@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-209113-14739@https.bugs.freebsd.org/bugzilla/> References: <bug-209113-14739@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209113 --- Comment #4 from rday <ryan@ryanday.net> --- I think you're right, a hard limit would be better. I can't find a maximum parameter count or a maximum parameter size in the documentation though. I don't think I'm familiar enough with the system to come up with a value. On the other hand, if root issues a malicious ioctl() then root's process just waits(using M_WAITOK). This doesn't seem like much of a concern. Lacking a sufficient hard limit, would it be best to simply change the `size` parameter's type to size_t? Removing the M_NOWAIT change? -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209113-14739-ot1FAojYV4>