From nobody Mon Feb 3 22:42:33 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yn1j86vgcz5mSfW; Mon, 03 Feb 2025 22:42:36 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yn1j83Ln9z3cr2; Mon, 03 Feb 2025 22:42:36 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTPS id f2IxtaUBzxv7Pf59HtOnz8; Mon, 03 Feb 2025 22:42:35 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id f59GtHiDPJhBPf59Ht1Ha0; Mon, 03 Feb 2025 22:42:35 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=QY3Fvdbv c=1 sm=1 tr=0 ts=67a1465b a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=T2h4t0Lz3GQA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=XX3NlJVnMeRn34Xq-24A:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id A2E4E118; Mon, 03 Feb 2025 14:42:33 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 72223189; Mon, 03 Feb 2025 14:42:33 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Doug Moore cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: ee511f83b386 - main - vm_reserv: use default pool for free page removal. In-reply-to: <202502032158.513LwUI8015476@gitrepo.freebsd.org> References: <202502032158.513LwUI8015476@gitrepo.freebsd.org> Comments: In-reply-to Doug Moore message dated "Mon, 03 Feb 2025 21:58:30 +0000." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 03 Feb 2025 14:42:33 -0800 Message-Id: <20250203224233.72223189@slippy.cwsent.com> X-CMAE-Envelope: MS4xfFAHRK0ogZQXeObO9yf0FqkMTU/5oY+RmTWkM/zAVcdG6uB8Iko21GK3N949tPxdfpZPCes4EvKfHKBdf02a6L86bEsN1NiI0sC9DWLgcSa1v0crLT1M XvZDwUXbysG90EP4qFWM6ULNKu2kd8t7yX6RRZYbeo1xHUZ7r61nnwz6NH7p+meD+rjg8l0R4y/NntzgIQ355mOBVhiXOTT1i+PVUnO0USdFjyh8/m+P721L PRviXWyA7S9q6z3HaK5J0vVTqSgKzk176uXvEF+dfzj6NxANNeB3+7TfPma1gD0KaDVpuNMDAumujdFiNO+LIbs4HSbFWhsWDjiBS2zf8K4= X-Rspamd-Queue-Id: 4Yn1j83Ln9z3cr2 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] In message <202502032158.513LwUI8015476@gitrepo.freebsd.org>, Doug Moore writes : > The branch main has been updated by dougm: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ee511f83b386299d9ad0b4e7b141eed1 > 28eddf2b > > commit ee511f83b386299d9ad0b4e7b141eed128eddf2b > Author: Doug Moore > AuthorDate: 2025-02-03 21:56:34 +0000 > Commit: Doug Moore > CommitDate: 2025-02-03 21:58:17 +0000 > > vm_reserv: use default pool for free page removal. > > Differential Revision: https://reviews.freebsd.org/D45409 Your description in the revision is an excellent description. Too bad it wasn't in the commit log. The summary in the revision tells us why. > --- > sys/vm/vm_reserv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sys/vm/vm_reserv.c b/sys/vm/vm_reserv.c > index 04453e050a38..1102cb61323a 100644 > --- a/sys/vm/vm_reserv.c > +++ b/sys/vm/vm_reserv.c > @@ -480,7 +480,8 @@ vm_reserv_depopulate(vm_reserv_t rv, int index) > if (rv->popcnt == 0) { > vm_reserv_remove(rv); > vm_domain_free_lock(vmd); > - vm_phys_free_pages(rv->pages, rv->pages->pool, VM_LEVEL_0_ORDER > ); > + vm_phys_free_pages(rv->pages, VM_FREEPOOL_DEFAULT, > + VM_LEVEL_0_ORDER); > vm_domain_free_unlock(vmd); > counter_u64_add(vm_reserv_freed, 1); > } > -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0