From owner-freebsd-net@freebsd.org  Thu Apr 21 05:12:02 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64917B16151
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Thu, 21 Apr 2016 05:12:02 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org
 [IPv6:2610:1c1:1:607c::16:b])
 by mx1.freebsd.org (Postfix) with ESMTP id 3F82514E3
 for <freebsd-net@freebsd.org>; Thu, 21 Apr 2016 05:12:02 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346)
 id 6A062D1F9; Thu, 21 Apr 2016 05:12:01 +0000 (UTC)
Date: Thu, 21 Apr 2016 05:12:01 +0000
To: freebsd-net@freebsd.org
From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org>
Reply-to: D5872+325+9dea0574509cdbb3@reviews.freebsd.org
Subject: [Differential] D5872: tcp: Don't prematurely drop receiving-only
 connections
Message-ID: <47345357f5c615fc29b42043217f7709@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
Thread-Topic: D5872: tcp: Don't prematurely drop receiving-only connections
X-Herald-Rules: <64>
X-Phabricator-To: <PHID-USER-owbigh336siepsaab2ye>
X-Phabricator-To: <PHID-PROJ-62ihepuxzgyzg7rh5uic>
X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-n3y55yy4j7xarsdk3otz>
X-Phabricator-To: <PHID-USER-aojo5yplx3m2nkpgwndr>
X-Phabricator-To: <PHID-USER-57eqaez2c2qhlyhs4xoi>
X-Phabricator-To: <PHID-USER-4lzxzqflpaankb5hk2y4>
X-Phabricator-To: <PHID-USER-dyyyzfp34mimhzvg33tk>
X-Phabricator-To: <PHID-PROJ-u7z45dkhkb4gc5luse77>
X-Phabricator-To: <PHID-USER-qmfo4xh7l6f2cud3zfo7>
X-Phabricator-To: <PHID-USER-hh4avozwa3ssphnwhjxx>
X-Phabricator-To: <PHID-USER-s22ldiy33wseno7vfmzs>
X-Phabricator-Cc: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-Cc: <PHID-USER-x2wszzhtr5egla5eo3md>
X-Phabricator-Cc: <PHID-USER-qmfo4xh7l6f2cud3zfo7>
Precedence: bulk
In-Reply-To: <differential-rev-PHID-DREV-5vu7wrfibtoing77xfvt-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-5vu7wrfibtoing77xfvt-req@FreeBSD.org>
Thread-Index: MmVmNzYzNzljOGQxMmM4MWI4MmNjYzcxMzczIFcYYSE=
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.21
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Apr 2016 05:12:02 -0000

sepherosa_gmail.com added a comment.


  In https://reviews.freebsd.org/D5872#128556, @hiren wrote:
  
  > In https://reviews.freebsd.org/D5872#128555, @lstewart wrote:
  >
  > > I thought that had been fixed ages ago... oops.
  >
  >
  > Fixed? i.e. doing something other than setting cwnd to 1 seg?
  >
  > > It should be calling cc_cong_signal() with a new congestion type.
  >
  > Hum... tcp_quench() used to be there which essentially had this 1 line to set cwnd to 1 seg.
  >
  > Is there any (RFC) guidance for what to do in this situation?
  
  
  I don't think there are any.

REVISION DETAIL
  https://reviews.freebsd.org/D5872

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, network, glebius, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, freebsd-net-list, transport, jtl, hiren, lstewart
Cc: gnn, mike-karels.net, jtl