From owner-freebsd-arm@FreeBSD.ORG Thu Dec 19 11:23:59 2013 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F31458FD for ; Thu, 19 Dec 2013 11:23:58 +0000 (UTC) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8434D15A1 for ; Thu, 19 Dec 2013 11:23:58 +0000 (UTC) Received: by mail-wi0-f178.google.com with SMTP id bz8so2010615wib.11 for ; Thu, 19 Dec 2013 03:23:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:organization:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=//l4WqSVLd6yXhR1S6UE4v7h6NwwdkmTKl/2gcyKjnU=; b=KvPA/YX3KL3vSW0/bglWsRUDbdqYLoIXDy/mLd6xFhK86NNf6b39ZlsknCIjNGOtBO hPtiD8/pzBrIpzvLziT1qsTS4WpSO6qHAwNJlMAbMUEeiYteGZJ68iDNtKEv109stbs7 cMNvGhbHt3oeSBWPQDeWSpNS9r6McdHmWZQ+f6XmNLhqpaLWQmC0/YyCFgDwqtS+rNNf 45yz7bF1Fq6nDgXHliJM86qUXOglJf4L74lKeWszJ3aOegSCTL8yZV3UA38O6pPz9DtM /zErB6BO9nHuMT8F6Rv6Y+VVNHgpEeJytzvq37k8Y6bdYAppyGFEofuw2yOE1IZR+qzi Ff0Q== X-Gm-Message-State: ALoCoQnivrkz7CD3GAYyO+du/vk/nlPZwQijZFz//03rotHjoCAe6v0ArZSwexHajI0LOADopr+Y X-Received: by 10.180.108.83 with SMTP id hi19mr1933481wib.26.1387452231319; Thu, 19 Dec 2013 03:23:51 -0800 (PST) Received: from [10.0.2.117] ([80.82.22.190]) by mx.google.com with ESMTPSA id fj8sm11283814wib.1.2013.12.19.03.23.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Dec 2013 03:23:50 -0800 (PST) Message-ID: <52B2D744.3090003@semihalf.com> Date: Thu, 19 Dec 2013 12:23:48 +0100 From: Zbigniew Bodek Organization: Semihalf User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Warner Losh Subject: Re: RFC: ARM related fixes - GIC, cache line size, PCI FDT & AHCI References: <52AF3D06.2000004@semihalf.com> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "freebsd-arm@freebsd.org" , br@freebsd.org, Olivier Houchard X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Dec 2013 11:23:59 -0000 Hello Warner, Thanks for your review. Please see below. Best regards zbb On 16.12.2013 22:50, Warner Losh wrote: > > On Dec 16, 2013, at 10:48 AM, Zbigniew Bodek wrote: > >> Hello Everyone. >> >> We would like to submit some new patches recently developed by Semihalf. > > Thanks for your efforts here. Would there be a need to MFC these patches to 10 and/or 9? [ZBB] We can take a look at that after committing to current. > >> You can find them here: >> http://people.freebsd.org/~zbb/Semihalf/12.2013/ >> >> Detailed description is available in the commit logs but in general: >> >> -- 0001-Resolve-cache-line-size-using-CP15.patch >> - use cache line size acquired in runtime > > This looks good (assuming the register definitions are good, I didn't verify them). Might be useful to publish these values to userland somehow, maybe via a sysctl. This is option, but would be nice to have. > > Would also be good to have USB_ALIGN kassert if using USB and this value is < that macro. > > Do other, older CPUs need similar decoding, or are the hard-wired values good? [ZBB] I have no knowledge about that. Someone who is using older ARMs should take a look. > >> -- 0002-GIC-polarity-and-level-support.patch >> - suport for setting trigger level and polarity in GIC > > This one seems to be OK, but is complicated enough that more eyeballs and testing would be good.... [ZBB] OK. Someone is testing this right now. > >> -- 0003-Add-PCI-FDT-interrupt-trigger-polarity-parsing.patch >> - trigger and polarity parsing for PCI FDT interrupts > > This patch might conflict. > > + if (trig) > + *trig = tmp_trig; > + if (pol) > + *pol = tmp_pol; > > Are not zero values also valid? [ZBB] Yeah. We will skip this patch for now. > >> -- 0004-Do-not-attach-to-bridges-in-AHCI-driver.patch > > I'd add the word 'PCI' before bridge in the comment, otherwise this looks good. [ZBB] OK. > >> -- 0005-Use-only-mapped-BIOs-on-ARM.patch > > A comment about what MVA is would be useful.. Otherwise does what it says. [ZBB]. This should refer to just Virtual Address (not "Modified") so we will change it back to VA. > >> - Two patches enabling the AHCI driver on ARM chips > > I didn't see these. Did I miss something? Or is the unmapped stuff all it takes? [ZBB] Yes, I meant the two above(0004 && 0005). > >> We will appreciate if you could post your comments and/or remarks by the >> end of this week when we plan to commit the changes. >> >> Best regards >> zbb >> _______________________________________________ >> freebsd-arm@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-arm >> To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org" >