From owner-dev-commits-ports-main@freebsd.org Thu Apr 29 09:46:00 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ECE1362101F; Thu, 29 Apr 2021 09:46:00 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FW9c85x2nz4WMP; Thu, 29 Apr 2021 09:46:00 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id A13677DF6; Thu, 29 Apr 2021 09:46:00 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:678:ab:0:3356:ef6b:256f:d0c6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 76065942D80; Thu, 29 Apr 2021 09:45:58 +0000 (UTC) Date: Thu, 29 Apr 2021 11:45:56 +0200 From: Mathieu Arnold To: Alexey Dokuchaev Cc: Adriaan de Groot , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: Please use conventional commit messages (Re: git: 2a9b7ca2a362) Message-ID: <20210429094556.usriaerpcgtgszwz@aching.in.mat.cc> References: <202104281017.13SAHDF2019723@gitrepo.freebsd.org> <2794032.slGk94SIus@beastie.bionicmutton.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bzvdrsrcovrg7uvu" Content-Disposition: inline In-Reply-To: X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2021 09:46:01 -0000 --bzvdrsrcovrg7uvu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 28, 2021 at 11:53:46AM +0000, Alexey Dokuchaev wrote: > On Wed, Apr 28, 2021 at 12:36:39PM +0200, Adriaan de Groot wrote: > > On Wednesday, 28 April 2021 12:17:13 CEST Alexey Dokuchaev wrote: > > > commit 2a9b7ca2a3620249bfad050ac3eee6d859926213 > > > ... > > >=20 > > > Update `www/web2ldap' to version 1.5.117. > >=20 > > Please use conventional commit messages, for consistency with the rest = of > > the ports commits and convenience for consumers -- humans looking at co= mmits > > through tools like email, qgit and gitk (desktop-applications), cgit (g= it-web > > browser) and git log (CLI). >=20 > I think it is conventional enough. I'd prefer it even better without the > embedded port name, but I guess I can buy the reasoning why people want to > see it there. As for its position, I find "foo/bar: blah" inconvenient, > unnatural, and hard to read. The format of a commit message is documented there: https://docs.freebsd.org/en/articles/committers-guide/#_commit_message_form= ats Please follow it. We all know you hate Git, but we switch to Git, and Subversion or CVS are not comming back, please move on like we all did. --=20 Mathieu Arnold --bzvdrsrcovrg7uvu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmCKgFBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgKckQ//WMApCZGAH5jmqL1m2E/vr6NXjSfhERvJnLeo/jyJBd5EPk2v0JPYCOrH 3f2d3HEFwm/j77mSVJbXG/3xbsEw2IS7985qdA2uusTMBG4sj5yqO/xDrOWQcLwh PsdP0hbCotk//f/dnpThsKMJmiu7tRNj6/j6FPd38860VJzg3uAxdOpsE5O2/y/d U5GxWVEvEEiey55+HpkbTgUVbOXdzDk6wPZNeA6YwrXHFeU/yRSehnwKpB4jxjGp G0aSTx4bF47n5neTN+X/32jJOhkHKQxDohH8NTT8cCQKnanwb7T/zOjMpakas1rV +ABehW49m5w9f1GtDllmbhtTHmy7OOzEDC3noC04J2MXrWKGO3nSSKy8jA0FiJK0 997cvAeI6cTEd6BpZNfIQ5FFE7FCbcfNlwalI4TFODNjISN1S5AqY227erfiD7T7 tv65vSBkbXdAQ1287SsSakMOd9j83NmmYG4S8ZFCWKCg9y9Yh/AkEw/4dsWORdCG r5aWwc5e1luwMMnudhggpztnwT5mq5Gt0hpIzZ1uvojokObIeS9pN2RblGMMrbnX n7N4oLA7qTxkyyYPw90jm02zFCr+hnv/VdhcpivUSqhIHSbvtI2rctpij2X8qlPI JqWRnf314hYGJXB9291TRiyJxXNMWFqLU7k04y/545Z6byZsBKQ= =S6ou -----END PGP SIGNATURE----- --bzvdrsrcovrg7uvu--