From owner-svn-src-all@freebsd.org Thu May 21 13:22:20 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6795F2CF951; Thu, 21 May 2020 13:22:20 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49SVf425Vkz3Tpk; Thu, 21 May 2020 13:22:20 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 3DD6219184; Thu, 21 May 2020 13:22:20 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f175.google.com with SMTP id 190so7191651qki.1; Thu, 21 May 2020 06:22:20 -0700 (PDT) X-Gm-Message-State: AOAM533L+q3akYZH8Hm3AktGLTYBVsIDRSvomesUt8MasgJbIOJ2uUKn RkOg5L4Xy3Dfj7yiAeclcOm2lV1zXf4gGh0H/UI= X-Google-Smtp-Source: ABdhPJwPNlOz8DvXWrAubV9uWBalHosO8xx70hqb4oCgaVHzKhEgqVLMNV5wj85z1FNAMVQfrODDR2Ko09SPT9Wp6MQ= X-Received: by 2002:a37:9f44:: with SMTP id i65mr4153785qke.103.1590067339676; Thu, 21 May 2020 06:22:19 -0700 (PDT) MIME-Version: 1.0 References: <202005210350.04L3ouOR031524@repo.freebsd.org> <202005211259.04LCxh0C016512@gndrsh.dnsmgr.net> In-Reply-To: <202005211259.04LCxh0C016512@gndrsh.dnsmgr.net> From: Kyle Evans Date: Thu, 21 May 2020 08:22:07 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r361318 - head/bin/ls To: "Rodney W. Grimes" Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2020 13:22:20 -0000 On Thu, May 21, 2020 at 7:59 AM Rodney W. Grimes wrote: > > > Author: kevans > > Date: Thu May 21 03:50:56 2020 > > New Revision: 361318 > > URL: https://svnweb.freebsd.org/changeset/base/361318 > > > > Log: > > ls: fix a --color regression from r337956 > > > > The regression is in-fact that I flipped the default from never to auto. The > > incorrect impression was based on an alias that I failed to notice, > > installed by the Linux distribution that I used for testing compatibility > > here. Users that want the old default should be doing so with a shell alias > > as is done elsewhere, rather than making this decision in ls(1). > > > > Many thanks to rgrimes for pointing out the alias that I clearly overlooked > > that resulted in this; if you despised colors in your terminal from this, > > consider buying him a beer at the next venue that you see him at. > > Thanks Kyle, but this is likely to get me more rocks than beers :-) > FWIW- I received a not-insignificant number of valid complaints about the original default change because default color schemes are hard, and continued to receive an insignificant number of complaints as recent as a couple months ago (~2 years after the change?). This is considerably more flack than I expect to receive from other controversial proposals I've made and it was based on a fundamental misunderstanding of coreutils. Thanks, Kyle Evans