From owner-cvs-all@FreeBSD.ORG  Thu Jun  1 09:58:13 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5ECEE16B3E5;
	Thu,  1 Jun 2006 09:58:13 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5ED7343DA9;
	Thu,  1 Jun 2006 09:57:45 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k519vdlg005891;
	Thu, 1 Jun 2006 03:57:44 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <447EBA65.9000103@samsco.org>
Date: Thu, 01 Jun 2006 03:59:01 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7.7) Gecko/20050416
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Maxim Konovalov <maxim@FreeBSD.org>
References: <200605311315.k4VDFUhD093628@repoman.freebsd.org>
In-Reply-To: <200605311315.k4VDFUhD093628@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.1
X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Jun 2006 09:58:18 -0000

Maxim Konovalov wrote:

> maxim       2006-05-31 13:15:29 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/ufs/ufs          ufs_vnops.c 
>   Log:
>   o According to POSIX, the result of ftruncate(2) is unspecified
>   for file types other than VREG, VDIR and shared memory objects.
>   We already handle VREG, VLNK and VDIR cases.  Silently ignore
>   truncate requests for all the rest.  Adjust comments.
>   
>   PR:             kern/98064
>   Submitted by:   bde
>   Security:       local DoS
>   Regress. test:  regression/fifo/fifo_misc
>   MFC after:      2 weeks
>   
>   Revision  Changes    Path
>   1.276     +22 -4     src/sys/ufs/ufs/ufs_vnops.c

If POSIX says that the result is undefined, wouldn't it be in our
best interests to return EBADF instead of 0?  Or would that break
3rd party software?

Scott