From owner-freebsd-current Tue Nov 16 0:58:43 1999 Delivered-To: freebsd-current@freebsd.org Received: from axl.noc.iafrica.com (axl.noc.iafrica.com [196.31.1.175]) by hub.freebsd.org (Postfix) with ESMTP id 2AEE4151C5 for ; Tue, 16 Nov 1999 00:58:38 -0800 (PST) (envelope-from sheldonh@axl.noc.iafrica.com) Received: from sheldonh (helo=axl.noc.iafrica.com) by axl.noc.iafrica.com with local-esmtp (Exim 3.040 #1) id 11neRC-000BhE-00; Tue, 16 Nov 1999 10:58:06 +0200 From: Sheldon Hearn To: Pierre Beyssac Cc: Bruce Evans , Garrett Wollman , freebsd-current@FreeBSD.ORG Subject: Re: egcs -O breaks ping.c:in_cksum() In-reply-to: Your message of "Tue, 16 Nov 1999 09:45:36 +0100." <19991116094536.A44999@enst.fr> Date: Tue, 16 Nov 1999 10:58:06 +0200 Message-ID: <44963.942742686@axl.noc.iafrica.com> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 16 Nov 1999 09:45:36 +0100, Pierre Beyssac wrote: > > - volatile u_short answer = 0; > > + union { > > + u_int16_t us; > > + u_int8_t uc[2]; > > + } answer; > Uh, which one(s) do you mean exactly? The 4-space indented union > (I just followed style(9)) The word ``union'' doesn't appear in style(9) and a 1 tab indent is used consistently in the examples of structs. Use 1 tab. > or the double space before uc[2] (it was just to align us and uc > vertically)? Use tabs for that as well. Look at the rest of ping.c, and you'll see that 4-space indents aren't used except to prevent line-wrap in one weird case of a switch block and for run-over lines. Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message