From owner-freebsd-hackers@FreeBSD.ORG Thu Mar 27 18:48:37 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1DB131F8 for ; Thu, 27 Mar 2014 18:48:37 +0000 (UTC) Received: from mail-oa0-x233.google.com (mail-oa0-x233.google.com [IPv6:2607:f8b0:4003:c02::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D7F4C644 for ; Thu, 27 Mar 2014 18:48:36 +0000 (UTC) Received: by mail-oa0-f51.google.com with SMTP id i4so4855705oah.24 for ; Thu, 27 Mar 2014 11:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=OKMNpE/TQafLmtsXgezatL4oQy5F7kn7RYo+M2D5Qeg=; b=bSz4tlSmlONdIpFG5nQZlcyLvOyZkMwiV04hZZh+w0vs17Cnus94hgHMlI9312scTV KtnChNuF0vq4d+wBo8Lr7DIMHr+BSt14p8pPOFB096ZcSN1keMBsr/AeXbRKMVr87Hgw 4S/0mlox917G7jumSFWBBij2HbCTtIAMCGPQHRPdHa02Qz/WVf+Gt16VzhEY6PaV7iol 81qs72cJ2R7PFzobnz488OIqsUCaIOtVOoSxcPphf3BumZia8BMItCBGYxhHDdjAnBVn nt0Z3+Pa/eylXR02j6BXpP1glma8l9KcsQ8CfkPMZJxMj5CM/Rvmt2wF7oezdiaF8O+L KC+Q== MIME-Version: 1.0 X-Received: by 10.60.44.135 with SMTP id e7mr2552585oem.63.1395946116098; Thu, 27 Mar 2014 11:48:36 -0700 (PDT) Received: by 10.76.115.129 with HTTP; Thu, 27 Mar 2014 11:48:36 -0700 (PDT) In-Reply-To: <20140325211355.GG21331@kib.kiev.ua> References: <20140316141216.GA21331@kib.kiev.ua> <20140319140236.GM21331@kib.kiev.ua> <20140325211355.GG21331@kib.kiev.ua> Date: Thu, 27 Mar 2014 14:48:36 -0400 Message-ID: Subject: Re: [PATCH] Support PCIe Alternative RID Interpretation (ARI) From: Ryan Stone To: Konstantin Belousov Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-hackers@freebsd.org" , Neel Natu X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2014 18:48:37 -0000 On Tue, Mar 25, 2014 at 5:13 PM, Konstantin Belousov wrote: > Well, either the interface I described is provided by pci core, or > iommu has to de-facto implement it itself. IMO it is clearer to have > it in pci, but I do not want to block your work on this. Yes, but this amounts to some simple masking and shifting on the RID. I don't think that's a very high burden. > I mean, that slot and func should be obtained using pci accessors where > needed. It is definitely not perf-critical, and I dislike having both > bsf and rid in the context structure more, then using accessors. Ok, I've updated the DMAR patch to use pci accessors instead. This required moving the initialization of ctx_tag.owner earlier in the initialization of the DMAR ctx, but beyond that the change was trivial.