From owner-svn-ports-head@freebsd.org Fri Sep 20 16:19:25 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5CCF1121C78; Fri, 20 Sep 2019 16:19:25 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mail.bsd4all.net (mail.bsd4all.net [144.76.30.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.bsd4all.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Zf711Zjyz4Mjp; Fri, 20 Sep 2019 16:19:24 +0000 (UTC) (envelope-from herbert@gojira.at) Date: Fri, 20 Sep 2019 18:19:22 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gojira.at; s=mail201809; t=1568996362; bh=JIz7WW5leu5iFVu8R/E5J2ugdDxurKo3KikuwbO0UWg=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=Hs9EpR3XJUIHpN7dXn5lIWZzpLb7Wu5sXvkEEfMNn00J05wpbXNiELWSZSBUzaPom VK9Rt92IU4K5ewiUktV2yh9NOzA7vZ0iPw4jNnupIkFrNEPq5CbTXoxq6srJFcXgiC XW99W5RxUNseIOsoqveqcSkRjn9NYLaADQxyQ2t+zZJpoou47yocD1xc2dBSBoP4D0 ahxmputWZ0niQUP7z0RGZM+IDoBAvbd3eRE0ee4ieZbdovTMXRXHGMGMDpZBDy6ABq i/HPDEfegEL6Luztcw8OtvT/CMnmrsvecBn/NYjkmkjf+ZK/GIK1viK/K75z5ocTEc Dgj4FaopsQ1gg== From: "Herbert J. Skuhra" To: "Sergey A. Osokin" Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r512184 - in head/www/nginx-devel: . files Message-ID: <20190920161922.GB58875@mail.bsd4all.net> References: <201909162038.x8GKcLoD070077@repo.freebsd.org> <87v9toaxaq.wl-herbert@gojira.at> <20190920122908.GG12076@FreeBSD.org> <20190920132055.GA58875@mail.bsd4all.net> <20190920133048.GH12076@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190920133048.GH12076@FreeBSD.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 46Zf711Zjyz4Mjp X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.995,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 16:19:25 -0000 On Fri, Sep 20, 2019 at 01:30:48PM +0000, Sergey A. Osokin wrote: > On Fri, Sep 20, 2019 at 03:20:55PM +0200, Herbert J. Skuhra wrote: > > On Fri, Sep 20, 2019 at 12:29:08PM +0000, Sergey A. Osokin wrote: > > > On Thu, Sep 19, 2019 at 09:41:33PM +0200, Herbert J. Skuhra wrote: > > > > On Mon, 16 Sep 2019 22:38:21 +0200, "Sergey A. Osokin" wrote: > > > > > > > > > > Author: osa > > > > > Date: Mon Sep 16 20:38:21 2019 > > > > > New Revision: 512184 > > > > > URL: https://svnweb.freebsd.org/changeset/ports/512184 > > > > > > > > > > Log: > > > > > Add the following third-party modules: > > > > > o) ip2location > > > > > o) ip2proxy > > > > > > > > > > Add third-party slice_ahead feature. > > > > > > > > > > Update third-party passenger module to the latest release 6.0.3. > > > > > > > > > > Switch third-party lua module dependence from lang/luajit (2.0) to > > > > > lang/luajit-openresty (2.1). > > > > > > > > > > Bump PORTREVISION. > > > > > > > > > > Modified: > > > > > head/www/nginx-devel/Makefile > > > > > head/www/nginx-devel/Makefile.extmod > > > > > head/www/nginx-devel/Makefile.options.desc > > > > > > > > head/www/nginx-devel/distinfo > > > > > head/www/nginx-devel/files/extra-patch-passenger-build-nginx.rb > > > > > head/www/nginx-devel/files/extra-patch-passenger-disable-telemetry > > > > > > > > This commit is obviously wrong/incomplete: > > > > > > > > 1. option HTTP_SLICE_AHEAD was added in wrong place > > > > 2. extra-patch-src_http_modules_ngx_http_slice_read_ahead.c is missing > > > > > > Hi Herbert, > > > > > > thanks for point me in. The missing patch has been found and added > > > to the port. > > > Could you please explain what does it mean HTTP_SLICE_AHEAD in a wrong > > > place. > > > > Hi Sergey, > > > > thanks. > > > > HTTP_SLICE_AHEAD is an external module but the option was added to > > "Modules that are part of the base nginx distribution". > > Got it, Herbert, here is the patch. Thanks. Looks good but I think the PORTVERSION bump is not really needed, is it? -- Herbert