From owner-freebsd-stable@FreeBSD.ORG Mon Nov 29 09:38:15 2004 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5457716A4CE; Mon, 29 Nov 2004 09:38:15 +0000 (GMT) Received: from relay.bestcom.ru (relay.bestcom.ru [217.72.144.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B86243D58; Mon, 29 Nov 2004 09:38:14 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (root@cell.sick.ru [217.72.144.68]) by relay.bestcom.ru (8.13.1/8.12.9) with ESMTP id iAT9cC9x034680 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 29 Nov 2004 12:38:13 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id iAT9cBU1001811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 29 Nov 2004 12:38:12 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id iAT9cBfR001810; Mon, 29 Nov 2004 12:38:11 +0300 (MSK) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Mon, 29 Nov 2004 12:38:11 +0300 From: Gleb Smirnoff To: Hideki Yamamoto , alfred@freebsd.org Message-ID: <20041129093811.GB1659@cell.sick.ru> References: <20041121.003425.41664309.yamamoto436@oki.com> <20041122081250.GA49670@cell.sick.ru> <20041128.213540.74733833.yamamoto436@oki.com> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20041128.213540.74733833.yamamoto436@oki.com> User-Agent: Mutt/1.5.6i X-Virus-Scanned: clamd / ClamAV version devel-20041013, clamav-milter version 0.75l on 127.0.0.1 X-Virus-Status: Clean cc: freebsd-stable@freebsd.org Subject: Re: pppoe server option X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Nov 2004 09:38:15 -0000 On Sun, Nov 28, 2004 at 09:35:40PM +0900, Hideki Yamamoto wrote: H> > -l switch configures label in ppp.conf H> > -p swicth configures provider name which is announced in Ethernet. H> H> Thank you for your reply. H> I think comment statement in /etc/defaults/rc.conf should be changed H> because the current comment means '-l'. Otherwise we should change H> /etc/rc.network. Don't you think so? H> H> -------------- /etc/defaults/rc.conf ---------- H> pppoed_provider="service-pppoe" # Provider and ppp(8) config file entry. H> ----------------------------------------------- [ccing Alfred, since cvs annotate points at him] If label has not been specified, it defaults to provider. So this comment is not meaningless. If you want to specify another label, you should use pppoed_flags variable. I think it will be better to change comment to "PPPoE Provider name". Alfred, what do you think? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE