Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Aug 2012 18:51:48 +0100
From:      Chris Rees <crees@FreeBSD.org>
To:        Hajimu UMEMOTO <ume@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r302395 - head/japanese/egg-canna
Message-ID:  <CADLo83-FGLaEs3dkdjnUgwcbTvZxLC=w-9WJu%2BLQpFFOU97SZg@mail.gmail.com>
In-Reply-To: <201208101744.q7AHiaYl059872@svn.freebsd.org>
References:  <201208101744.q7AHiaYl059872@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 10 August 2012 18:44, Hajimu UMEMOTO <ume@freebsd.org> wrote:
> Author: ume
> Date: Fri Aug 10 17:44:35 2012
> New Revision: 302395
> URL: http://svn.freebsd.org/changeset/ports/302395
>
> Log:
>   It doesn't build with Emacs 24.
>
> Modified:
>   head/japanese/egg-canna/Makefile
>
> Modified: head/japanese/egg-canna/Makefile
> ==============================================================================
> --- head/japanese/egg-canna/Makefile    Fri Aug 10 17:28:10 2012        (r302394)
> +++ head/japanese/egg-canna/Makefile    Fri Aug 10 17:44:35 2012        (r302395)
> @@ -24,8 +24,8 @@ USE_EMACS=    yes
>
>  .include <bsd.port.pre.mk>
>
> -.if ${EMACS_PORT_NAME} == "emacs23"
> -IGNORE=                does not build with Emacs 23
> +.if ${EMACS_PORT_NAME} == "emacs23" || ${EMACS_PORT_NAME} == "emacs24"
> +IGNORE=                does not build with Emacs 23 and later

Alternatively:

.if ${EMACS_MAJOR_VER} >= 23

can be used and is more obvious what it means.  It also has the
advantage of working should Xemacs23 appear ;)

Chris



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-FGLaEs3dkdjnUgwcbTvZxLC=w-9WJu%2BLQpFFOU97SZg>