From owner-freebsd-bugs@FreeBSD.ORG Sun Jan 24 13:30:02 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ADF30106566C for ; Sun, 24 Jan 2010 13:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 717B28FC0C for ; Sun, 24 Jan 2010 13:30:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0ODU2io064461 for ; Sun, 24 Jan 2010 13:30:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0ODU20Z064459; Sun, 24 Jan 2010 13:30:02 GMT (envelope-from gnats) Resent-Date: Sun, 24 Jan 2010 13:30:02 GMT Resent-Message-Id: <201001241330.o0ODU20Z064459@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alexander Egorenkov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 55BE0106568D for ; Sun, 24 Jan 2010 13:24:46 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 457268FC1D for ; Sun, 24 Jan 2010 13:24:46 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o0ODOjrP027226 for ; Sun, 24 Jan 2010 13:24:46 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o0ODOjgm027217; Sun, 24 Jan 2010 13:24:45 GMT (envelope-from nobody) Message-Id: <201001241324.o0ODOjgm027217@www.freebsd.org> Date: Sun, 24 Jan 2010 13:24:45 GMT From: Alexander Egorenkov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/143163: Radiotap bug in ieee80211_sta.c:sta_input X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jan 2010 13:30:02 -0000 >Number: 143163 >Category: kern >Synopsis: Radiotap bug in ieee80211_sta.c:sta_input >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jan 24 13:30:01 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Alexander Egorenkov >Release: FreeBSD 8.0 STABLE >Organization: >Environment: FreeBSD dantooine 8.0-RELEASE FreeBSD 8.0-RELEASE #2: Tue Dec 15 17:56:06 CET 2009 root@dantooine:/usr/obj/usr/src/sys/MYKERNEL i386 >Description: I have found a bug in ieee80211_sta.c:sta_input which causes some problems with wireshark. Here is a code fragment: ------------------------------------------------------ /* copy to listener after decrypt */ if (ieee80211_radiotap_active_vap(vap)) ieee80211_radiotap_tx(vap, m); <------- Bug need_tap = 0; ------------------------------------------------------ >How-To-Repeat: I have found this bug by analyzing data packets with wireshark. It causes wireshark to display wrong data. Sniff some incoming packets with wireshark on a WLAN NIC. >Fix: he function sta_input handles incoming packets in STA mode in net80211 stack. Thus, the right thing to do would be to call ieee80211_radiotap_rx(vap, m) and not ieee80211_radiotap_tx(vap, m) >Release-Note: >Audit-Trail: >Unformatted: