From owner-freebsd-amd64@FreeBSD.ORG Thu Jun 2 12:38:32 2005 Return-Path: X-Original-To: freebsd-amd64@freebsd.org Delivered-To: freebsd-amd64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4827116A41C; Thu, 2 Jun 2005 12:38:32 +0000 (GMT) (envelope-from jspedron@club-internet.fr) Received: from smtp.cegetel.net (mf00.sitadelle.com [212.94.174.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id B35DC43D1F; Thu, 2 Jun 2005 12:38:31 +0000 (GMT) (envelope-from jspedron@club-internet.fr) Received: from [172.16.142.1] (213-223-184-201.dti.cegetel.net [213.223.184.201]) by smtp.cegetel.net (Postfix) with ESMTP id 69B7A1A42AA; Thu, 2 Jun 2005 14:38:27 +0200 (CEST) Message-ID: <429EFDC1.6040905@club-internet.fr> Date: Thu, 02 Jun 2005 14:38:25 +0200 From: =?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a6) Gecko/20050208 X-Accept-Language: fr-fr, fr, en-us, en, ja MIME-Version: 1.0 To: obrien@freebsd.org References: <429D860A.5000608@club-internet.fr> <429DFEA1.8000004@club-internet.fr> <200506011833.12686.jkim@niksun.com> <20050602082615.GA36096@dragon.NUXI.org> In-Reply-To: <20050602082615.GA36096@dragon.NUXI.org> X-Enigmail-Version: 0.90.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigC6997053FA7B93B9E39A6752" Content-Transfer-Encoding: 8bit Cc: freebsd-ia64@freebsd.org, freebsd-ppc@freebsd.org, freebsd-amd64@freebsd.org, freebsd-alpha@freebsd.org Subject: Re: [CALL FOR TESTERS] ReiserFS on non-i386 hardware patch X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2005 12:38:32 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC6997053FA7B93B9E39A6752 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit David O'Brien wrote: > On Wed, Jun 01, 2005 at 06:33:12PM -0400, Jung-uk Kim wrote: > >>The kernel module doesn't load because of an amd64-specific GCC 3.4 >>optimization bug. To work around: >> >>Index: Makefile >>=================================================================== >>RCS file: /home/ncvs/src/sys/modules/reiserfs/Makefile,v >>retrieving revision 1.1 >>diff -u -r1.1 Makefile >>--- Makefile 24 May 2005 12:30:13 -0000 1.1 >>+++ Makefile 1 Jun 2005 22:22:52 -0000 >>@@ -8,4 +8,8 @@ >> reiserfs_namei.c reiserfs_prints.c reiserfs_stree.c \ >> reiserfs_vfsops.c reiserfs_vnops.c >> >>+.if ${MACHINE_ARCH} == "amd64" >>+CFLAGS+= -minline-all-stringops >>+.endif >>+ > > Unfortunately we really don't like to put this type of CFLAGS in non-*.mk > files. Since we know the GCC 3.4.2 compiler bugs will be fixed, I > suggest we just document this issue and be happy that otherwise the code > is ready to go on FreeBSD/amd64. Thank you Jung-Ku and David for your feedback. Olivier Houchard could test it on amd64 too and found another workaround for this same issue. The problem come from this macro: #define INITIALIZE_PATH(var) \ struct path var = { ILLEGAL_PATH_ELEMENT_OFFSET, } where gcc generates a call to memset(). By replacing it with: #define INITIALIZE_PATH(var) \ struct path var; \ bzero(&var); \ var.path_length = ILLEGAL_PATH_ELEMENT_OFFSET it works. I can add this (in favor of the CFLAGS workaround) and document it. When a fixed gcc will be in the tree, it'll be removed. -- Jean-Sébastien Pédron http://www.dumbbell.fr/ PGP Key: http://www.dumbbell.fr/pgp/pubkey.asc --------------enigC6997053FA7B93B9E39A6752 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFCnv3Ja+xGJsFYOlMRAqrpAJ4ze67ysxFGJVNSX5YGdIbTos3tEwCeODRC GAXpNeLbN2Y3+IvvmxJaLao= =A2AX -----END PGP SIGNATURE----- --------------enigC6997053FA7B93B9E39A6752--