From owner-freebsd-ports Sat Feb 23 4:30:10 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 5E21E37B402 for ; Sat, 23 Feb 2002 04:30:02 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g1NCU2376053; Sat, 23 Feb 2002 04:30:02 -0800 (PST) (envelope-from gnats) Received: from mailout11.sul.t-online.com (mailout11.sul.t-online.com [194.25.134.85]) by hub.freebsd.org (Postfix) with ESMTP id 49A9437B400 for ; Sat, 23 Feb 2002 04:27:32 -0800 (PST) Received: from fwd02.sul.t-online.de by mailout11.sul.t-online.com with smtp id 16ebDR-0005bq-09; Sat, 23 Feb 2002 13:23:49 +0100 Received: from spirit.corecode.ath.cx (320050403952-0001@[217.224.175.39]) by fmrl02.sul.t-online.com with esmtp id 16ebDF-05gnkOC; Sat, 23 Feb 2002 13:23:37 +0100 Received: from elevation.zuhause.stoert.net (elevation.zuhause.stoert.net [192.168.66.46]) by spirit.corecode.ath.cx (8.11.6/8.11.6) with ESMTP id g1NCNae93950 for ; Sat, 23 Feb 2002 13:23:36 +0100 (CET) (envelope-from corecode@corecode.ath.cx) Received: (from corecode@localhost) by elevation.zuhause.stoert.net (8.11.6/8.11.6) id g1NCNZb90375; Sat, 23 Feb 2002 13:23:35 +0100 (CET) (envelope-from corecode) Message-Id: <200202231223.g1NCNZb90375@elevation.zuhause.stoert.net> Date: Sat, 23 Feb 2002 13:23:35 +0100 (CET) From: "Simon 'corecode' Schubert" Reply-To: "Simon 'corecode' Schubert" To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: ports/35239: wwww/linux-netscape6 doesn't respect WRKDIRPREFIX, IS_INTERACTIVE Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 35239 >Category: ports >Synopsis: wwww/linux-netscape6 doesn't respect WRKDIRPREFIX, IS_INTERACTIVE >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Feb 23 04:30:01 PST 2002 >Closed-Date: >Last-Modified: >Originator: Simon 'corecode' Schubert >Release: FreeBSD 4.5-STABLE i386 >Organization: >Environment: System: FreeBSD elevation.zuhause.stoert.net 4.5-STABLE FreeBSD 4.5-STABLE #6: Sat Feb 9 22:49:14 CET 2002 corecode@elevation.zuhause.stoert.net:/usr/obj/i386/k7/usr/src/sys/ELEVATION i386 ports cvsupped every day 02:00 CET (-0100) >Description: linux-netscape6 doesn't respect WRKDIRPREFIX when assigning DISTFILES furthermore error output isn't 2>/dev/null this results is garbage being used when portsdb(1) updates the db. the supplied scripts/configure checks for BATCH but the port itself doesn't set IS_INTERACTIVE. this breaks building the port unattended. >How-To-Repeat: cd /usr/ports/wwww/linux-netscape6 make -V DISTFILES -V IS_INTERACTIVE >Fix: consider something like this: --- Makefile.orig Sat Feb 23 13:15:41 2002 +++ Makefile Sat Feb 23 13:21:20 2002 @@ -69,13 +69,20 @@ PLIST= ${WRKDIR}/pkg-plist STARTUP_CMD= netscape6 +.if !defined(BATCH) +IS_INTERACTIVE= yes +.endif + .include +.if exists(${WRKSRC}/components.conf) +DISTFILES!= ${CAT} ${WRKSRC}/components.conf 2>/dev/null +.endif + pre-everything:: ${MKDIR} ${WRKSRC}/bin/plugins ${WRKSRC}/bin/chrome \ ${WRKSRC}/plugins ${SETENV} ${SCRIPTS_ENV} ${SH} ${SCRIPTDIR}/configure -DISTFILES!=${CAT} ${.CURDIR}/work/${WRKSRC}/components.conf; ${TRUE} do-extract: .for i in ${DISTFILES} >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message