From owner-freebsd-fs@freebsd.org Mon May 20 16:05:13 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1701015B135F; Mon, 20 May 2019 16:05:13 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BFC984C62; Mon, 20 May 2019 16:05:12 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from onlyone.not-for.work (onlyone.not-for.work [IPv6:2a01:4f8:201:6350::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: lev/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 11C611D185; Mon, 20 May 2019 16:05:12 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from [192.168.23.186] (unknown [89.113.128.32]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.not-for.work (Postfix) with ESMTPSA id A215C186C0; Mon, 20 May 2019 19:05:07 +0300 (MSK) From: Lev Serebryakov Subject: Commit r345200 (new ARC reclamation threads) looks suspicious to me - second potential problem Reply-To: lev@FreeBSD.org To: freebsd-fs@freebsd.org, freebsd-hackers@FreeBSD.org, Alexander Motin Openpgp: preference=signencrypt Autocrypt: addr=lev@FreeBSD.org; prefer-encrypt=mutual; keydata= mQINBFKbGksBEADeguVs+XyJc3mL3iiOBqDd16wSk97YTJYOi4VsHsINzJr09oFvNDiaDBIi fLn2p8XcJvehcsF2GSgrfXfw+uK4O1jyNIKJmiYA0EtE+ZbRtvDrrE0w6Q8+SDeKA21SWh3Y vSQ0DJUontbgW55ER2CbEiIUTIn34uQ0kmESAaw/v5p/9ue8yPTmURvv130FqPFz8VPzltqL NxyGt54TxPfKAzAHEIwxlEZ63JOwzloKh1UDBExcsf9nJO08/TAVgR5UZ5njFBPzaaquhRoP qPJLEQQDqxPIlvMNtHKf7iIebE4BHeqgCdJA0BoiR6gpa0wlsZtdrTPK3n4wYSphLvGbhfOZ YW/hbcu7HYS/FImkVxB3iY17kcC1UTnx4ZaYeASPBGOOPbXky1lLfmDGWIFT//70yx+G17qD OZzF1SvJJhGvh6ilFYaWMX7T+nIp6Mcafc4D7AakXM+XdubNXOMlCJhzPcZ0skgAEnYV587w V7em5fDVwQccwvtfezzqKeJAU5TGiywBHSR5Svzk2FwRNf6M//hWkpq0SRR63iOhkHGOAEBi 69GfEIwH2/w24rLxP0E+Hqq8n+EWNkPatw1Mhcl5PKkdvGCjJUaGNMkpBffjyYo254JXRscR eEnwdIkJt4ErDvjb2/UrOFq31wWMOiLzJeVchAgvTHBMRfP9aQARAQABtCFMZXYgU2VyZWJy eWFrb3YgPGxldkBGcmVlQlNELm9yZz6JAlYEEwEIAEACGwMHCwkIBwMCAQYVCAIJCgsEFgID AQIeAQIXgBYhBPltHKC19DGLZ0szCuqwPFi/3EePBQJb/TeXBQkPBbfGAAoJEOqwPFi/3EeP LtEQANQLS89OCDSnLDZLyCj7sH5GZbTikJp9Or2McqEOpjgtfY/OgqCe7lfo8f71tTN3gL2t VGtNEtsl6CqKeBdm6fqsetCAed2+waJfbXLZWReLRSFQJ/cbof8MB3h/uEw8Zng1ZbyEU0eG rc41Mhk8bTfxjNRjkXDbp0+2xug+eRr2RYhiY2SxH+iy57AbRIu9gkjfL05VztfvsV5dPxt7 +reHf2Vhtu+qCRtCytGQqDvYWGpVZ8U5fHJxFdsJpn66LAe8w+iRGCbppB5TKeHkqWqDb++u sd5ZHzwep/7qcLBeKggi8+a2C3J1J4TpYBwdPgusrGtBPf2EYSTc/0mW5j86g1l8UDN9qXAI FvWbKf22p5SlYUzf5qRLny4ZdDl1mH13lmJV7ZkZGMKnt0IjJ2x0LRgLGhiSm/D4Lh8yc/MX uhj9BB020XbWcMUPpA7S7YaWeIXbnK3NrPU0yk77prFJblfskOwuaxJIwa2mX+cCAQA95As5 2talifo4Kh8OLSvS1gpbMo64LllTzuGbCWuKecH3fpMlZlD7/10z9lBvkSXA7KgadDfN0yHO xGCK8KE9gXXmEVRlbgGDYOJw9FLWHuSZHUvQTkmr4goXrmMIKa9A4BKO3s9vowP4pJ0vp3kz MIBeEwKSvAeZZfgKbIKggKUuQ5gsAqvF360sG3+UuQINBFKbGksBEAC0a9wfjo2P3JyT7Lc+ QlbFVshGbSbazb4ma7QYG5IZZD5vfLBFkePoG6cnrn3WCXp4A43hszAynCwe4eXyAkv4+gPF 3ZSeNE5Wz3zYG+jh2nm2iGCkyaVykfbA+2chor2DKH5tHpuNMBlF+wSJHZKJmlo/sFIktAnV 1NBVg4/cL+9/hIpvl82cl3hYCD7/e7/qRE+w38CpAAzn65FvbODn7xlY3fsJt+cHPBJ4EBM9 KnTwcce+F+72RQMZQEl7vIAwSRmLdgZHN0MFC533l62SVoKjT0eaOOIBrvesmojhWjfwugib Xr+WRF/tGcW77Bxwe2eQLbEVESqWeMORxRxocx7Q7aACoHmf4G4U1Vzx7zUEfNfHjfjZeQVf AURf/MoUelZSW/BmMIfKCg3lRlWAt+Pq2h2UADPVqAZze45beE/c8z8LZsOZiGoRhYL8NSg6 +ziLTdmYLWdtFGAuZhqOtNp5h6tGj21OksBotcaIa5YjbCmmnImIjGlSBkUKvIhq/RXth5b2 gNwaQdu+Yv4AlZVHRsuVywL/skDFL5+We11bDK6MQ5PzvmntRJcgbyoisn1hiV04OV1LpJJM kJn1j8VlBqDQNT/z+BjB0ru/0anv+5uLj7v0ck06rEo4yiXT/ZAcBM76j7V7FaGbkoba6bUU CQ2H5YYBOKpikjCnpwARAQABiQI8BBgBCAAmAhsMFiEE+W0coLX0MYtnSzMK6rA8WL/cR48F Alv9N7IFCQ8Ft+cACgkQ6rA8WL/cR49wpw//W7QrZHKYUWEVHtPLVMlcM1f7MgwnYlIRe/I6 gykwvt87sqxSYu7eHxfX6JZR2M9UYuUYscSR57gxXKu2Uzqaz2KjvEIXJCwCTsuXZjkQ19oL hAPsucw2AcMI6YqPXbZ7hO0Mh8jMeJzD6vDvx3zvunQxGQoZKxr3BvRUyO7NCYbA7N8ccI3E Tmdjj9JTbtue9WaUeGLszFDiITmkASBdsK07y4ylLAJzUGCvYLBU3gx0bBOB2S8SbxHYmQlj ewjovbp+MbT+CoXNxZp+gDRModGyIMdRIotkRiDbgNl0VWIT0SS1GUUlUHKzQ/ZPUvpvk6Gq s/SYBS7rBQNSoXXmJxNW6I6atVNW7JhInC1tkHxBlbpik4FK07J6NHFTx+9ygyCxbxwNA/Le FGkL3kU0VFXR2dNiAVbeueUPF6tU5Bye5ftgpLKOSAbo1g++EKUkc8335/4oYRBMcGEk4xUr NAvzoFPhA2W3KtklruJ9ThrFt9+//NB5ySlVgTwGWMuBJoskEmNOTBv34/UQPUIuE4xSwy6y H+nRQJooiMFo5QCosslJPlwyV63NS9lYXB6n3QWOCP6sFdWACNUCOFv4uk7LQdY9BsCmt2Tk cLuHmoS+fvUesQXnYV2aQi9HciriPIj2gvJ6WjgiaC/PpePil0fzyrfG/JMyHL0qcgmYoj0= Organization: FreeBSD Message-ID: <369cb1e9-f36a-a558-6941-23b9b811825a@FreeBSD.org> Date: Mon, 20 May 2019 19:05:07 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UjA9hsut7pP6HXGyYiI8hkW1DMFekAsUU" X-Rspamd-Queue-Id: 4BFC984C62 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 May 2019 16:05:13 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UjA9hsut7pP6HXGyYiI8hkW1DMFekAsUU Content-Type: multipart/mixed; boundary="e5XAhQSTvMSs9v9w4opHL9AcywXVm0rTy"; protected-headers="v1" From: Lev Serebryakov Reply-To: lev@FreeBSD.org To: freebsd-fs@freebsd.org, freebsd-hackers@FreeBSD.org, Alexander Motin Message-ID: <369cb1e9-f36a-a558-6941-23b9b811825a@FreeBSD.org> Subject: Commit r345200 (new ARC reclamation threads) looks suspicious to me - second potential problem --e5XAhQSTvMSs9v9w4opHL9AcywXVm0rTy Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable I'm looking at last commit to 'sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c' (r345200) and have another question. Here are such code: 4960 /* 4961 * Kick off asynchronous kmem_reap()'s of all our caches. 4962 */ 4963 arc_kmem_reap_soon(); 4964 =09 4965 /* 4966 * Wait at least arc_kmem_cache_reap_retry_ms between 4967 * arc_kmem_reap_soon() calls. Without this check it is possible to 4968 * end up in a situation where we spend lots of time reapin= g 4969 * caches, while we're near arc_c_min. Waiting here also gives the 4970 * subsequent free memory check a chance of finding that th= e 4971 * asynchronous reap has already freed enough memory, and we don't 4972 * need to call arc_reduce_target_size(). 4973 */ 4974 delay((hz * arc_kmem_cache_reap_retry_ms + 999) / 1000); 4975 =09 But looks like `arc_kmem_reap_soon()` is synchronous on FreeBSD! So, this `delay()` looks very wrong. Am I right? Looks like it should be `#ifdef illumos`. --=20 // Lev Serebryakov --e5XAhQSTvMSs9v9w4opHL9AcywXVm0rTy-- --UjA9hsut7pP6HXGyYiI8hkW1DMFekAsUU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE+W0coLX0MYtnSzMK6rA8WL/cR48FAlzi0DNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY5 NkQxQ0EwQjVGNDMxOEI2NzRCMzMwQUVBQjAzQzU4QkZEQzQ3OEYACgkQ6rA8WL/c R4/G2xAAgTzfzeDRycWw5jwlXWAJwExJh4ItBjDoWwe1U+1Yn0tcd+ZbsZX2iH2K R6MJllylJlYF/VHc1Np022vViKrP0bj9vG26QsRjhXZSoGvBYf9exPEp7GMmO81b U6Rm6JyUeuPvc19Kqusrk3FV2CWtu5dUqgp68n5cmujyztZLi1wobRapAHZ+YnrZ SdwnAF28E9LucgNIb4obbe00gkRNlgfXMhMeVi7Q+If/FTJOApoB5dZRdqkv80DF 7wmRhd/423k3ETrkGbRkJNXkWM2jIU13WAbFLbgcDcHZptdePIA2vQ5/CL1W0yV7 1ShZIk3jLgSI/Ue55UpJkf6kgEhZ9v7fOUCNaN5+BhgEut+shVY+Yd7meii7+vsh 6rOVyuXuOoFZFqbkDSLxhLz/zF/zm3Ee9KTIC8WTyuGpHxtFWY6InJFXlZIoiV+A 6gHbYUoKpDOuSwjW+HsGrSEZfZVaH9PeRb7P8UUu6pcrU6UFJFvnX9zqrG/4Hrvi NHCf8rweBnMUuimmeAa6H4kX7sOaK93azqLrk6wuSQYvZ69r8KIcsRKI6Up48rtn pQgT8bJOG5z4Ayk/PYRcltmug/SCGJnf+dtEDgomLb+qsBUdpmP6j4a9Wcxo66pz 4xUmyU2KzqFmx7Gj2oswGTZk1QS+ONj5dhza0gt+gGZU0CFDaWU= =V3Nd -----END PGP SIGNATURE----- --UjA9hsut7pP6HXGyYiI8hkW1DMFekAsUU--