From owner-freebsd-current@FreeBSD.ORG Sat May 23 01:00:13 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D15F106566B for ; Sat, 23 May 2009 01:00:13 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [195.88.108.3]) by mx1.freebsd.org (Postfix) with ESMTP id E5BA38FC13 for ; Sat, 23 May 2009 01:00:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 7E5CD41C7A4; Sat, 23 May 2009 03:00:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([195.88.108.3]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id ISw-RlFucZTr; Sat, 23 May 2009 03:00:06 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id 2105B41C7A3; Sat, 23 May 2009 03:00:06 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 5F79C4448E6; Sat, 23 May 2009 00:58:13 +0000 (UTC) Date: Sat, 23 May 2009 00:58:13 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Rick Macklem In-Reply-To: Message-ID: <20090523005657.W72053@maildrop.int.zabbadoz.net> References: X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-current@freebsd.org Subject: Re: sys/nfsserver/nfs_srvkrpc.c doesn't build with KGSSAPI X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 May 2009 01:00:13 -0000 On Fri, 22 May 2009, Rick Macklem wrote: > I just noticed that sys/nfsserver/nfs_srvkrpc.c doesn't build when > options KGSSAPI is specified. > > "hostname" is undefined > > This appears to be because it is now inside: > > #ifdef VIMAGE_GLOBALS > ... > #endif > in sys/sys/kernel.h. > > I figured I'd let someone more familiar with what VIMAGE_GLOBALS is used > for decide how best to fix this. This is because you neither use G_hostname (always global as in base system) or V_hostname (viertualized one; per network stack). See sys/vimage.h and other usages in sys/ for how to properly handle this. /bz -- Bjoern A. Zeeb The greatest risk is not taking one.