From owner-freebsd-net Mon Sep 24 1:19:47 2001 Delivered-To: freebsd-net@freebsd.org Received: from sasami.jurai.net (sasami.jurai.net [64.0.106.45]) by hub.freebsd.org (Postfix) with ESMTP id 748FF37B412 for ; Mon, 24 Sep 2001 01:19:45 -0700 (PDT) Received: from localhost (winter@localhost) by sasami.jurai.net (8.9.3/8.8.7) with ESMTP id EAA96969; Mon, 24 Sep 2001 04:19:42 -0400 (EDT) Date: Mon, 24 Sep 2001 04:19:42 -0400 (EDT) From: "Matthew N. Dodd" To: Jonathan Lemon Cc: net@freebsd.org Subject: Re: review request. In-Reply-To: <20010923190346.B79251@prism.flugsvamp.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sun, 23 Sep 2001, Jonathan Lemon wrote: > > Right; rather than failing the detach routines will fuss about it so you > > know exactly how you screwed up. I don't see this papering anything over. > > Because this is not a normal operational error. If anything, the > statement should be a KASSERT(), but I don't really see the need for it. bpfdetach() already has a test for this case; adding one to if_detach() doesn't seem like a bad thing so long as abusing if_index isn't a problem. -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message