From owner-freebsd-fs@freebsd.org Tue Dec 4 07:08:53 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5904013269BE for ; Tue, 4 Dec 2018 07:08:53 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EFB7669ED9; Tue, 4 Dec 2018 07:08:52 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from mousie.catspoiler.org (unknown [76.212.85.177]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: truckman) by smtp.freebsd.org (Postfix) with ESMTPSA id 4883A17100; Tue, 4 Dec 2018 07:08:52 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Date: Mon, 3 Dec 2018 23:08:50 -0800 (PST) From: Don Lewis Subject: Re: stuck with ufs CHECK-HASH errors To: Kirk McKusick cc: freebsd-fs@FreeBSD.org In-Reply-To: <201812040602.wB462lPD091248@chez.mckusick.com> Message-ID: References: <201812040602.wB462lPD091248@chez.mckusick.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=us-ascii Content-Disposition: INLINE X-Rspamd-Queue-Id: EFB7669ED9 X-Spamd-Result: default: False [-1.62 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-0.91)[-0.909,0]; NEURAL_HAM_SHORT(-0.08)[-0.083,0]; NEURAL_HAM_LONG(-0.63)[-0.628,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 07:08:53 -0000 On 3 Dec, Kirk McKusick wrote: > I am working on a fix. Hopefully have it in no more than a day. I figured out that ufs_disk_fillout() and therefore sbread() in libufs is never getting called. Therefore the superblock used by cgput() is all zeros. If I change the call to ufs_disk_fillout_blank() in setup() to ufs_disk_fillout() then things appear to work much better.