From owner-svn-src-all@FreeBSD.ORG Mon Aug 9 06:03:58 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E8AD1065670; Mon, 9 Aug 2010 06:03:58 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id AB7148FC20; Mon, 9 Aug 2010 06:03:56 +0000 (UTC) Received: by wyj26 with SMTP id 26so12098425wyj.13 for ; Sun, 08 Aug 2010 23:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=4Fc5TmgyNHFsV/h7gCk9zjOk92MrISjV8mZtKfy+iw0=; b=IvEsp4Xp8kAqf2yZijUlTfitM4EBGzjRWHRNzqzthb4TMa5aui0yZUWD95p4Vlpytm rYwrvXSiympSGF805uzzbV2FA1DURzQTTWnv1F77oOsyt7yFmV9B+azPkHtP2umx0YsZ R7HifP/qkcR/plx4aDINfjVVYd5X3fLxY31v4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=jOK4geI22OfvdkdGTY6QbA7QX6dKsddNeH/TS2+gGfYg0gI+myWDjumQrqY5K4LsA9 P+rtgJyvSJAwT5cTtyNVNEV394FXxaWvgKqbzw1A2hIbcygyBmVFNWMLoagp6FUhVFts OBIpupBnokJZOWTeM2oXuWPEe0TISLi32N9OU= MIME-Version: 1.0 Received: by 10.216.203.71 with SMTP id e49mr13418244weo.60.1281333358320; Sun, 08 Aug 2010 22:55:58 -0700 (PDT) Received: by 10.216.160.10 with HTTP; Sun, 8 Aug 2010 22:55:58 -0700 (PDT) In-Reply-To: References: <201005161943.o4GJhnTo096839@svn.freebsd.org> Date: Mon, 9 Aug 2010 11:25:58 +0530 Message-ID: From: "Jayachandran C." To: Attilio Rao Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: src-committers@freebsd.org, John Baldwin , "Jayachandran C." , svn-src-all@freebsd.org, Joe Landers , Randall Stewart , sbruno@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r208165 - in head/sys: kern mips/conf mips/include mips/mips mips/rmi mips/rmi/dev/xlr X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Aug 2010 06:03:58 -0000 On Mon, Aug 9, 2010 at 5:31 AM, Attilio Rao wrote: > 2010/5/16 Randall Stewart : >> Author: rrs >> Date: Sun May 16 19:43:48 2010 >> New Revision: 208165 >> URL: http://svn.freebsd.org/changeset/base/208165 >> >> Log: >> =A0This pushes all of JC's patches that I have in place. I >> =A0am now able to run 32 cores ok.. but I still will hang >> =A0on buildworld with a NFS problem. I suspect I am missing >> =A0a patch for the netlogic rge driver. >> >> =A0JC check and see if I am missing anything except your >> =A0core-mask changes > > >> Modified: head/sys/kern/subr_smp.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sys/kern/subr_smp.c =A0 =A0Sun May 16 19:25:56 2010 =A0 =A0 =A0= =A0(r208164) >> +++ head/sys/kern/subr_smp.c =A0 =A0Sun May 16 19:43:48 2010 =A0 =A0 =A0= =A0(r208165) >> @@ -503,7 +503,10 @@ smp_topo_none(void) >> =A0 =A0 =A0 =A0top =3D &group[0]; >> =A0 =A0 =A0 =A0top->cg_parent =3D NULL; >> =A0 =A0 =A0 =A0top->cg_child =3D NULL; >> - =A0 =A0 =A0 top->cg_mask =3D (1 << mp_ncpus) - 1; >> + =A0 =A0 =A0 if (mp_ncpus =3D=3D sizeof(top->cg_mask) * 8) >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 top->cg_mask =3D -1; >> + =A0 =A0 =A0 else >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 top->cg_mask =3D (1 << mp_ncpus) - 1; >> =A0 =A0 =A0 =A0top->cg_count =3D mp_ncpus; >> =A0 =A0 =A0 =A0top->cg_children =3D 0; >> =A0 =A0 =A0 =A0top->cg_level =3D CG_SHARE_NONE; >> > > ... and this is why I particulary hate big commits with complete lack > of technical details. > > This particulary chunk was supposed to fix a nasty and completely MI > bug that some users have already met (kern/148698). The complete lack > of details didn't help in identify the issue neither that it was a > valuable fix. > > The fix is, however, improper (there is no clear relationship between > the multiplication and why that happens) thus I would rather use what > Joe has reported in the PR. I was not aware of the PR when I sent this changes to rrs@, and this went as a part of MIPS SMP support for XLR which has 32 CPUs But I'm not sure that the current change is correct, cg_mask is of type cpumask_t and I don't think it is guaranteed to be 32 bit (as it is a machine dependent type). JC.