From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Aug 8 12:50:17 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D31416A4E5 for ; Tue, 8 Aug 2006 12:50:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C86F743D53 for ; Tue, 8 Aug 2006 12:50:16 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k78CoGKr076267 for ; Tue, 8 Aug 2006 12:50:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k78CoGnR076263; Tue, 8 Aug 2006 12:50:16 GMT (envelope-from gnats) Resent-Date: Tue, 8 Aug 2006 12:50:16 GMT Resent-Message-Id: <200608081250.k78CoGnR076263@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stefan Sperling Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C60A16A4DF for ; Tue, 8 Aug 2006 12:40:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9080F43D53 for ; Tue, 8 Aug 2006 12:40:10 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k78CdsRR037781 for ; Tue, 8 Aug 2006 12:39:54 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k78CdsOg037780; Tue, 8 Aug 2006 12:39:54 GMT (envelope-from nobody) Message-Id: <200608081239.k78CdsOg037780@www.freebsd.org> Date: Tue, 8 Aug 2006 12:39:54 GMT From: Stefan Sperling To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: ports/101653: multimedia/mplayer depends on imake if WITHOUT_X11 is set X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Aug 2006 12:50:17 -0000 >Number: 101653 >Category: ports >Synopsis: multimedia/mplayer depends on imake if WITHOUT_X11 is set >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Aug 08 12:50:15 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Stefan Sperling >Release: FreeBSD 6.1-RELEASE-p3 >Organization: >Environment: FreeBSD gurke.stsp.lan 6.1-RELEASE-p3 FreeBSD 6.1-RELEASE-p3 #3: Mon Aug 7 08:28:26 CEST 2006 stsp@gurke.stsp.lan:/usr/obj/usr/src/sys/GURKE i386 >Description: First of all, a big thank you to whoever finally cleaned up the configuration options mess and made the mplayer port heed make config :) I guess there was a small oversight though. If WITHOUT_X11 is set, mplayer has a build dependency on imake. This doesn't really make sense. >How-To-Repeat: Set WITHOUT_X11=yes in /etc/make.conf. Install mplayer and note that it wants to install imake as a dependency. >Fix: Proposed patch, which assumes that someone made a logic error and that imake is actually needed if building with X11: --- Makefile.orig Tue Aug 8 14:00:01 2006 +++ Makefile Tue Aug 8 14:00:08 2006 @@ -216,10 +216,10 @@ .if defined(WITHOUT_X11) WITHOUT_GUI= yes -BUILD_DEPENDS+= imake:${X_IMAKE_PORT} CONFIGURE_ARGS+=--disable-x11 .else USE_XLIB= yes +BUILD_DEPENDS+= imake:${X_IMAKE_PORT} CONFIGURE_ARGS+=--with-x11libdir=${X11BASE}/lib \ --with-x11incdir=${X11BASE}/include .endif >Release-Note: >Audit-Trail: >Unformatted: