From owner-dev-commits-src-main@freebsd.org  Mon May  3 19:31:03 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 15F1E63B48F;
 Mon,  3 May 2021 19:31:03 +0000 (UTC)
 (envelope-from allanjude@freebsd.org)
Received: from tor1-11.mx.scaleengine.net (tor1-11.mx.scaleengine.net
 [IPv6:2001:470:1:474::25])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FYtPM026Kz3Pb9;
 Mon,  3 May 2021 19:31:02 +0000 (UTC)
 (envelope-from allanjude@freebsd.org)
Received: from [10.1.1.3] (senat1-01.HML3.ScaleEngine.net [209.51.186.5])
 (Authenticated sender: allanjude.freebsd@scaleengine.com)
 by tor1-11.mx.scaleengine.net (Postfix) with ESMTPSA id 2952D9F64;
 Mon,  3 May 2021 19:30:56 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.10.3 tor1-11.mx.scaleengine.net 2952D9F64
Subject: Re: git: 64881da47807 - main - ixgbe: Restore AIM support
To: Kevin Bowling <kevin.bowling@kev009.com>, Mark Johnston <markj@freebsd.org>
Cc: dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org,
 src-committers@freebsd.org
References: <202105031755.143Htj33046938@gitrepo.freebsd.org>
 <CAK7dMtCRTHW5f9qe-ZPaRZGaoUGNoQvLFKeMQcrDesevghEQ4g@mail.gmail.com>
From: Allan Jude <allanjude@freebsd.org>
Message-ID: <295b05d0-58ba-6e04-6fbf-cb997c9ab112@freebsd.org>
Date: Mon, 3 May 2021 15:30:55 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <CAK7dMtCRTHW5f9qe-ZPaRZGaoUGNoQvLFKeMQcrDesevghEQ4g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Rspamd-Queue-Id: 4FYtPM026Kz3Pb9
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 May 2021 19:31:03 -0000

On 5/3/2021 2:12 PM, Kevin Bowling wrote:
> Should we enable this by default?  My primary concern in the review is
> not making things like this require expert tuning.  If it is expected to
> be necessary, which Gallatin@ makes a case for, let’s toggle it on by
> default.
> 
> On Mon, May 3, 2021 at 10:56 AM Mark Johnston <markj@freebsd.org
> <mailto:markj@freebsd.org>> wrote:
> 
>     The branch main has been updated by markj:
> 
>     URL:
>     https://cgit.FreeBSD.org/src/commit/?id=64881da478071431a2d9e62613997a5772c56cdf
>     <https://cgit.FreeBSD.org/src/commit/?id=64881da478071431a2d9e62613997a5772c56cdf>
> 
>     commit 64881da478071431a2d9e62613997a5772c56cdf
>     Author:     Sai Rajesh Tallamraju <stallamr@netapp.com
>     <mailto:stallamr@netapp.com>>
>     AuthorDate: 2021-05-03 17:45:00 +0000
>     Commit:     Mark Johnston <markj@FreeBSD.org>
>     CommitDate: 2021-05-03 17:47:14 +0000
> 

It looks like AIM was on by default in 11.x and earlier:
hw.ix.enable_aim: 1
hw.igb.enable_aim: 1

So I think enabling it does make sense in light of Drew's comments about
mbuf sorting only being useful in the face of something like AIM where
there will be a sufficient number of mbufs to sort.

-- 
Allan Jude