From owner-freebsd-bugs@FreeBSD.ORG Mon Jul 7 19:41:25 2014 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4B8DCE23 for ; Mon, 7 Jul 2014 19:41:25 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2E4022984 for ; Mon, 7 Jul 2014 19:41:25 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s67JfPkC018710 for ; Mon, 7 Jul 2014 20:41:25 +0100 (BST) (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 191720] New: minor cut-and-paste error in pwd_mkdb Date: Mon, 07 Jul 2014 19:41:25 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: turingsboy@yahoo.com X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2014 19:41:25 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191720 Bug ID: 191720 Summary: minor cut-and-paste error in pwd_mkdb Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: turingsboy@yahoo.com There appears to be a cut-and-paste error in one spot in pwd_mkdb. I am unsure of how it affects users, if it does at all. Here is the patch: --- pwd_mkdb.c.orig 2014-07-07 12:29:15.019698896 -0700 +++ pwd_mkdb.c 2014-07-07 12:30:08.125795430 -0700 @@ -341,21 +341,21 @@ main(int argc, char *argv[]) * user. When operating on `old format' databases, this * would result in applications `seeing' only the updated * entries. */ key.data = verskey; key.size = sizeof(verskey)-1; data.data = &version; data.size = 1; if ((dp->put)(dp, &key, &data, 0) == -1) error("put"); - if ((dp->put)(sdp, &key, &data, 0) == -1) + if ((sdp->put)(sdp, &key, &data, 0) == -1) error("put"); } ypcnt = 0; data.data = (u_char *)buf; sdata.data = (u_char *)sbuf; key.data = (u_char *)tbuf; for (cnt = 1; scan(fp, &pwd); ++cnt) { if (!is_comment && (pwd.pw_name[0] == '+' || pwd.pw_name[0] == '-')) { yp_enabled = 1; By grepping the file, we can see that everywhere else in the file uses sdp->put instead of dp->put: $ grep put pwd_mkdb.c.orig | grep sdp 5:351: if ((dp->put)(sdp, &key, &data, 0) == -1) 13:437: if ((sdp->put)(sdp, &key, &sdata, method) == -1) 15:445: if ((sdp->put)(sdp, &key, &sdata, method) == -1) 17:453: if ((sdp->put)(sdp, &key, &sdata, methoduid) == -1) 21:464: if ((sdp->put)(sdp, &key, &sdata, method) == -1) 29:527: if ((sdp->put)(sdp, &key, &sdata, method) == -1) 31:535: if ((sdp->put)(sdp, &key, &sdata, method) == -1) 33:543: if ((sdp->put)(sdp, &key, &sdata, methoduid) == -1) 37:554: if ((sdp->put)(sdp, &key, &sdata, method) == -1) 41:584: if ((sdp->put)(sdp, &key, &data, method) == -1) 45:590: if ((sdp->put)(sdp, &key, &data, method) == -1) -- You are receiving this mail because: You are the assignee for the bug.